Skip to content

Conversation

wangyoucao577
Copy link
Contributor

mbedtls requires -lbcrypt on windows since v3.5.0, otherwise undefined reference to BCryptGenRandom will occur, see more in ChangeLog.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [build] Area: Changes in build files labels Jan 8, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Jan 8, 2024
@maxsharabayko maxsharabayko merged commit 7899f15 into Haivision:master Jan 8, 2024
@tommyvct
Copy link
Contributor

This PR is does not work. bcrypt will not be linked if SSL_LIBRARIES is not empty.

tommyvct added a commit to tommyvct/srt that referenced this pull request Jan 20, 2024
PR Haivision#2842 doens't fix the problem in all cases. This PR will only link to bcrypt if mbedtls is not found by find_package(mbedtls).
@wangyoucao577 wangyoucao577 deleted the bugfix/mbedtls-build branch January 20, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants