[core] Overlapped send with 100 ms timeout on Windows. #2834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxsharabayko Them used same WSAOVERLAPPED, so WSASendTo maybe not completed when WSAWaitForMultipleEvents return. From https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-wsasendto
|
This was referenced Jan 2, 2024
mGaosi
added a commit
to mGaosi/srt
that referenced
this pull request
Jan 22, 2024
…#2838). The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. This reverts commit b1c0be2. resolves Haivision#2632 Haivision#2834 Haivision#2838
mGaosi
added a commit
to mGaosi/srt
that referenced
this pull request
Jan 22, 2024
…#2838). The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. This reverts commit b1c0be2. resolves Haivision#973 Haivision#2632 Haivision#2834 Haivision#2838
mGaosi
added a commit
to mGaosi/srt
that referenced
this pull request
Jan 26, 2024
…#2838). The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. This reverts commit b1c0be2. resolves Haivision#973 Haivision#2632 Haivision#2834 Haivision#2838
This was referenced Feb 22, 2024
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 16, 2024
Overlapped send with 100 ms timeout on Windows added a data race.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 16, 2024
The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838. Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 16, 2024
Overlapped send with 100 ms timeout on Windows added a data race.
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 16, 2024
The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838. Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Apr 17, 2024
The lpOverlapped parameter must be valid for the duration of the overlapped operation. If multiple I/O operations are simultaneously outstanding, each must reference a separate WSAOVERLAPPED structure. Resolves Haivision#973, Haivision#2632, Haivision#2834, Haivision#2838. Co-authored-by: Jiangjie Gao <gaojiangjie@live.com>
maxsharabayko
added a commit
that referenced
this pull request
Apr 17, 2024
Overlapped send with 100 ms timeout on Windows added a data race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An infinite hand up on the
WSAGetOverlappedResultwas observed when transferring files using srt-xtransmit on Windows.Therefore adding a timeout of 100 ms to wait for the result.
This PR is mainly a reincarnation of #974.
SRT version with the issue: v1.5.3 (after PR #2632).