[core] To fix missing new link update when no transmission on existing links #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An imaginable possible solution:
|
|
The test has been adopted for #2444 and it passes there. That PR is then considered a replacement for this one. |
ethouris
pushed a commit
to ethouris/srt
that referenced
this pull request
Sep 10, 2024
|
Ok, there are still some mysterious fixes here that need not be cleared also with #2444. Need to investigate. |
|
Moved more changes to #2444, removal of the m_listener field from the group. The test still passes. Changes here now remain as adding the SRT_EPOLL_UPDATE event to the group upon new connection; need to figure out what problems this change is going to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft, adds a Unit Test that shows where the problem is and it is now failing.