Skip to content

Fix: AWS identitystore: failed if there are no instances #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2023
Merged

Fix: AWS identitystore: failed if there are no instances #1815

merged 2 commits into from
Dec 23, 2023

Conversation

vgavro
Copy link
Contributor

@vgavro vgavro commented Dec 11, 2023 •
edited
Loading

Fix crashing on importing AWS identitystore, if there are no instances, reproduced on current master.
closes #1808

terraformer import aws --resources=identitystore --regions=us-west-2
....

2023/12/11 20:06:06 aws importing... identitystore
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/GoogleCloudPlatform/terraformer/providers/aws.(*IdentityStoreGenerator).GetIdentityStoreId(0xc0038b90d0?)
	/Users/sergey/temp/terraformer/providers/aws/identitystore.go:44 +0x1ce
github.com/GoogleCloudPlatform/terraformer/providers/aws.(*IdentityStoreGenerator).InitResources(0x0?)
	/Users/sergey/temp/terraformer/providers/aws/identitystore.go:169 +0x25
github.com/GoogleCloudPlatform/terraformer/providers/aws.(*AwsFacade).InitResources(0xc0020449b0?)
	/Users/sergey/temp/terraformer/providers/aws/aws_facade.go:61 +0x26
github.com/GoogleCloudPlatform/terraformer/cmd.initServiceResources({_, _}, {_, _}, {{0xc0012df800, 0x56, 0x80}, {0x12999268, 0x0, 0x0}, ...}, ...)
	/Users/sergey/temp/terraformer/cmd/import.go:209 +0x21e
github.com/GoogleCloudPlatform/terraformer/cmd.initAllServicesResources(_, {{0xc0012df800, 0x56, 0x80}, {0x12999268, 0x0, 0x0}, {0xb20575b, 0x1e}, {0xb15cdd8, ...}, ...}, ...)
	/Users/sergey/temp/terraformer/cmd/import.go:166 +0x1c5
github.com/GoogleCloudPlatform/terraformer/cmd.Import({_, _}, {{0xc0012df800, 0x56, 0x80}, {0x12999268, 0x0, 0x0}, {0xb20575b, 0x1e}, ...}, ...)
	/Users/sergey/temp/terraformer/cmd/import.go:98 +0x2a5
github.com/GoogleCloudPlatform/terraformer/cmd.importRegionResources({{0xc0008300e0, 0x1, 0x1}, {0x12999268, 0x0, 0x0}, {0xb20575b, 0x1e}, {0xb15cdd8, 0x9}, ...}, ...)
	/Users/sergey/temp/terraformer/cmd/provider_cmd_aws.go:121 +0x292
github.com/GoogleCloudPlatform/terraformer/cmd.newCmdAwsImporter.func1(0xc00131ab00?, {0xb14e4f4?, 0x2?, 0x2?})
	/Users/sergey/temp/terraformer/cmd/provider_cmd_aws.go:58 +0xa0e
github.com/spf13/cobra.(*Command).execute(0xc00131ab00, {0xc000191240, 0x2, 0x2})
	/Users/sergey/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:850 +0x67c
github.com/spf13/cobra.(*Command).ExecuteC(0xc000de58c0)
	/Users/sergey/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:958 +0x39d
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/sergey/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:895
github.com/GoogleCloudPlatform/terraformer/cmd.Execute()
	/Users/sergey/temp/terraformer/cmd/root.go:36 +0x1e
main.main()
	/Users/sergey/temp/terraformer/main.go:39 +0x50

@google-cla Google CLA
Copy link

google-cla bot commented Dec 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vgavro vgavro mentioned this pull request Dec 11, 2023
Closed
@heldersepu
Copy link

is there anyone maintaining this project?

@sergeylanzman sergeylanzman enabled auto-merge (squash) December 23, 2023 05:28
@sergeylanzman sergeylanzman merged commit 8f78e79 into GoogleCloudPlatform:master Dec 23, 2023
ErikAtSumo pushed a commit to SumoLogic/terraformer that referenced this pull request Feb 25, 2025
@vgavro @ErikAtSumo
Fix: AWS identitystore: failed if there are no instances (GoogleCloud…
3431425 
…Platform#1815)

* fix: aws identitystore: failed if there are no instances

* fix: aws identitystore: failed if there are no instances (fixed tabs to match project style)
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2025
Merged
@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@heldersepu heldersepu heldersepu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error index out of range [0] with length 0 for identitystore
3 participants
@vgavro @heldersepu @sergeylanzman