Skip to content

Added codecommit approval rule template #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2023
Merged

Added codecommit approval rule template #1759

merged 3 commits into from
Sep 20, 2023

Conversation

shblue21
Copy link
Contributor

@shblue21 shblue21 commented Jul 27, 2023 •
edited
Loading

This PR adds support to aws_codecommit_approval_rule_template

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/codecommit_approval_rule_template#last_modified_user

Exported example:

resource "aws_codecommit_approval_rule_template" "tfer--codecommit_template_test" {
  content = <<CONTENT
{
  "DestinationReferences": [
    "ref/master"
  ],
  "Statements": [
    {
      "ApprovalPoolMembers": [
        "CodeCommitApprovers:ss2"
      ],
      "NumberOfApprovalsNeeded": 3,
      "Type": "Approvers"
    }
  ],
  "Version": "2018-11-08"
}
CONTENT

  description = "codecommit_template_test_Template"
  name        = "codecommit_template_test"
}

@sergeylanzman
Copy link
Collaborator

@shblue21 can you fix linter?

@sergeylanzman sergeylanzman enabled auto-merge (squash) September 20, 2023 09:14
@sergeylanzman sergeylanzman merged commit e8b1dd7 into GoogleCloudPlatform:master Sep 20, 2023
@shblue21
Copy link
Contributor Author

@sergeylanzman Thank you for your hard work.

ErikAtSumo pushed a commit to SumoLogic/terraformer that referenced this pull request Feb 25, 2025
@shblue21 @ErikAtSumo
Added codecommit approval rule template (GoogleCloudPlatform#1759)
0068e65 
* feat(codecommit): split InitResources into loadRepository and loadApprovalRuleTemplate methods

* feat(codecommit): added PostConverHook for json content.

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeylanzman sergeylanzman sergeylanzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shblue21 @sergeylanzman