Increase the amount of time an auth token is considered "valid" #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0s from now, instead of token.IsValid(), which only allows tokens that expire up to 255s from now.
MeBaranov
approved these changes
Jun 25, 2025
dziemba
added a commit
to dziemba/buildbuddy
that referenced
this pull request
Jul 31, 2025
https://github.com/GoogleCloudPlatform/docker-credential-gcr/releases/tag/v2.1.30 Contains a fix that avoids rare credentials errors when using GCE/GKE metadata server: GoogleCloudPlatform/docker-credential-gcr#183
sluongng
pushed a commit
to dziemba/buildbuddy
that referenced
this pull request
Aug 5, 2025
https://github.com/GoogleCloudPlatform/docker-credential-gcr/releases/tag/v2.1.30 Contains a fix that avoids rare credentials errors when using GCE/GKE metadata server: GoogleCloudPlatform/docker-credential-gcr#183
sluongng
pushed a commit
to buildbuddy-io/buildbuddy
that referenced
this pull request
Aug 5, 2025
https://github.com/GoogleCloudPlatform/docker-credential-gcr/releases/tag/v2.1.30 Contains a fix that avoids rare credentials errors when using GCE/GKE metadata server: GoogleCloudPlatform/docker-credential-gcr#183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until last year an auth token was considered valid if it didn't expire in the next 10 seconds, but this was changed to 255s last year in https://github.com/googleapis/google-cloud-go/pull/9139/files. This is causing issues with tokens returned from GKE Metadata server, which may be almost expired, expecting a refresh in the background. Let's revert to the previous behavior of allowing tokens to be used until they're within 10s of expiry, and then refreshing them at that time.
It would be more optimal to refresh in the background, but for now I want to do this simpler fix and revert to our previous behavior.
Fixes #182.