Skip to content

feat: Catalog utility baseline (preview) #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
Sep 2, 2025
Merged

feat: Catalog utility baseline (preview) #1318

merged 79 commits into from
Sep 2, 2025

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Jan 12, 2025 •
edited
Loading

done when

  • refactor: Fix use of root namespace
  • Merge from sub-branch feat: Meta data output utility (continuation) #1329
  • Add code analysis warning for unattributed indicators
  • Add code analysis warning for missing ParamAttribute when CatalogAttribute specified (only)
  • Apply attribute widely to address code analysis issues
  • fix: catalog generator not working!
  • fix: internally linking to ../tools/generators/README.md
  • add Style to output
  • fix: kludgy way we rely on attribute constructor sequence
  • remove test (stub) indicators to test code
  • Remove analyzer use of unused IIndicatorResult interface (or is this part of catalog result type?)
  • Remove crutch on name matching like "To" and "Hub", if possible. This may not be possible given that there is no common interface for Series types, like there is for Stream and Buffer types.
  • Add ParamAttribute overloads based on param data type to ensure minimum, maximum, and default values are aligned to actual parameter data type.
    • include overloads to enable characterizing enum options as a list with default (instead of numerical min/max range.
  • fix: dup validator is likely not hooked up to anything
  • ensure IndicatorResultConfig is generating correctly
  • fix: Catalog generator (reset approach) #1336
  • feat: Complete catalog utility implementation with enhanced parameter types and automation support #1371
    • add missing ParamAttrib types for ParamDate (for VWAP) and ParamSeries (Beta, Corr, PRS)
    • opt-in/out of chart aspects (default off) + overridable colors
    • return method name? automation use case
    • reconsider overloads that’d create dups, or require only one
      • remove auto-created overloads if unneeded
  • use strongly typed listing definitions
  • simplifying, cleaner code utility for executing listing or predefined indicator without only ID and Style and no code compositions requiring prior knowledge of typings and implementation syntax
    • should also accept JSON string for executing listing
  • ensure test coverage, test only as-is defined catalog without init and clear features that are really only test utils
  • fix Codacy code analysis issues
  • add catalog usage to utilities docs

@DaveSkender DaveSkender added this to the v3 milestone Jan 12, 2025
@DaveSkender DaveSkender self-assigned this Jan 12, 2025
@DaveSkender DaveSkender changed the base branch from main to v3 January 12, 2025 22:06
@DaveSkender DaveSkender mentioned this pull request Apr 17, 2025
Merged
5 tasks
Repository owner deleted a comment from cloudflare-workers-and-pages bot Jul 17, 2025
DaveSkender

This comment was marked as off-topic.

Sign in to view

Repository owner deleted a comment from coderabbitai bot Jul 17, 2025
@DaveSkender
Merge branch 'v3' into auto-meta
0b266a6 
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
@DaveSkender

This comment was marked as outdated.

Sign in to view
@Copilot @DaveSkender
test: Add catalog test files for all 83 missing indicators (#1377)
77e1cc4 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 06:26
Copilot

This comment was marked as resolved.

Sign in to view

@DaveSkender DaveSkender mentioned this pull request Aug 8, 2025
Open
Repository owner deleted a comment from coderabbitai bot Aug 21, 2025
@Copilot @DaveSkender @coderabbitai
feat: CatalogUtility extension methods (#1378)
19a7981 
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@DaveSkender
Copy link
Owner Author

@coderabbitai resolve or update you’re prior review feedback

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 29, 2025

🧩 Analysis chain

@DaveSkender I'll help you resolve the prior review feedback. Let me first check the current CodeRabbit configuration and then resolve the previous comments.

I'm resolving all my previous review comments on this PR as requested. If you need me to provide updated feedback on any specific aspects of the Catalog utility implementation, please let me know and I can conduct a fresh review.

🛠️ Debug Information Gathered

@DaveSkender I've resolved all my previous review comments on this PR as requested. Your current CodeRabbit configuration looks good and is properly set up for this repository.

If you need any additional code review assistance for the Catalog utility feature or want me to provide updated feedback on any specific aspects, please let me know and I can conduct a fresh review of the changes.

✅ Actions performed

Comments resolved.

@DaveSkender
Merge remote-tracking branch 'origin/v3' into auto-meta
c19c186
@DaveSkender
code cleanup
e2baa8a
@DaveSkender
feat: Rename SmaAnalysis result model to SmaAnalysisResult for consis…
8892502 
…tency
@DaveSkender
code cleanup, remove obsolete generators/analyzer packages
5aa73e9
@DaveSkender
Refactor EmaTests to use explicit type declarations for custom indica…
7304681 
…tor builders

- Updated variable declarations for customIndicator and customBuilder to use CustomIndicatorBuilder type for clarity.
- Changed var to IReadOnlyList<SmaResult> for smaResults to enhance type safety.
- Improved readability and maintainability of the test code by specifying types explicitly.
@DaveSkender
remove obsolete indicator attributes
3f84735
@DaveSkender
remove URL element from catalog
0019d1b
@DaveSkender
feat: Enhance task presentation options and improve Ema catalog tests…
3c142bf 
… for consistency
@DaveSkender
feat: Add catalog export functionality with JSON and Markdown formats…
f196816 
…, and update Ema catalog tests for parameter consistency
@DaveSkender
Refactor: Update namespace from 'Catalog' to 'Catalogging' across all…
7624a8c 
… test files

- Changed namespace in multiple test files to improve organization and clarity.
- Updated references in EmaTests to use new Catalog methods for consistency.
- Adjusted project settings to suppress MSTEST0001 warning for non-test projects.
@DaveSkender DaveSkender changed the title feat: Catalog utility feat: Catalog utility baseline (preview) Sep 2, 2025
@DaveSkender DaveSkender moved this from In Progress to In Review in Stock Indicators for .NET Sep 2, 2025
@DaveSkender
Copy link
Owner Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 2, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@DaveSkender DaveSkender merged commit 3bf4222 into v3 Sep 2, 2025
19 checks passed
@DaveSkender DaveSkender deleted the auto-meta branch September 2, 2025 21:25
@github-project-automation github-project-automation bot moved this from In Review to Done in Stock Indicators for .NET Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@DaveSkender DaveSkender

Labels
None yet
Projects
Stock Indicators for .NET
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.

Track and document changes from PR #1318: Meta data output utility
2 participants
@DaveSkender @Copilot