-
Notifications
You must be signed in to change notification settings - Fork 257
test: Add catalog test files for all 83 missing indicators #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DaveSkender
merged 5 commits into
auto-meta
from
copilot/fix-4418f99c-ec9f-4d45-883f-52fd80f70494
Jul 30, 2025
Merged
test: Add catalog test files for all 83 missing indicators #1377
DaveSkender
merged 5 commits into
auto-meta
from
copilot/fix-4418f99c-ec9f-4d45-883f-52fd80f70494
Jul 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Copilot finished work on behalf of
DaveSkender
July 30, 2025 02:17
This comment was marked as outdated.
This comment was marked as outdated.
DaveSkender
requested changes
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix failing tests
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Fixed all failing catalog tests. All 151 tests now pass (100% success rate). The issues were:
Created analysis scripts to parse all catalog files accurately and updated the test files with correct metadata expectations. Commit: 1cd48e7 |
Copilot finished work on behalf of
DaveSkender
July 30, 2025 05:51
DaveSkender
requested changes
Jul 30, 2025
Co-authored-by: DaveSkender <8432125+DaveSkender@users.noreply.github.com>
Copilot finished work on behalf of
DaveSkender
July 30, 2025 06:13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the catalog testing infrastructure by adding test files for all indicators that had catalog definitions but were missing corresponding test files.
Problem
The repository had 84 catalog files (
*.Catalog.cs
) but only 1 corresponding test file (Ema.Catalog.Tests.cs
), leaving 83 indicators without catalog test coverage. According to the catalog instructions, every catalog file should have a corresponding test file to validate metadata, parameters, and results.Solution
Created 83 new catalog test files following the established patterns:
AddEnumParameter
), date parameters (AddDateParameter
), listing name variants with "(Stream)" and "(Buffer)" suffixes, and result count/display name mismatchesWithName()
calls in catalog source files since the Style property already contains this informationTest Results
Implementation Details
namespace Catalog;
convention andTestBase
inheritanceThis ensures the catalog system has proper test coverage and validates that indicator metadata is correctly defined and accessible through the automation APIs.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.