Skip to content

chore: update baggage telemetry truncated name #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 19, 2025
Merged

chore: update baggage telemetry truncated name #6297

merged 3 commits into from
Aug 19, 2025

Conversation

rachelyangdog
Copy link
Contributor

What does this PR do?

  • updates baggage telemetry truncated name to be context_header.truncated instead of context_header_style.truncated to follow the existing dd-go metrics

Motivation

Plugin Checklist

Additional Notes

@rachelyangdog rachelyangdog requested a review from a team as a code owner August 18, 2025 14:28
@rachelyangdog rachelyangdog requested a review from ida613 August 18, 2025 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Overall package size

Self size: 11.86 MB
Deduped: 111.47 MB
No deduping: 111.82 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.1.0 | 20.37 MB | 20.37 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.1 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-08-18 16:45:47

Comparing candidate commit ca413a1 in PR branch rachel.yang/telemetry-name-update with baseline commit bf13fa7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1271 metrics, 52 unstable metrics.

BridgeAR
BridgeAR previously approved these changes Aug 18, 2025
View reviewed changes
@BridgeAR BridgeAR dismissed their stale review August 18, 2025 14:59

Tests missing

@codecov Codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (bf13fa7) to head (ca413a1).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6297   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         476      476           
  Lines       19996    19996           
=======================================
  Hits        16741    16741           
  Misses       3255     3255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BridgeAR
BridgeAR reviewed Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems fine, it would just be good to verify these in a test :)

@datadog-official Datadog Official
Copy link

datadog-official bot commented Aug 18, 2025 •
edited
Loading

⚠️ Tests

⚠️ Warnings

❄️ 5 New flaky tests detected

cypress@10.2.0 esm can report code coverage if it is available from integration-tests/cypress/cypress.spec.js (Datadog) 
Cannot read properties of undefined (reading 'payload')
cypress@10.2.0 esm can run and report tests from integration-tests/cypress/cypress.spec.js (Datadog) 
Cannot destructure property 'content' of 'testSessionEvent' as it is undefined.
cypress@10.2.0 esm catches errors in hooks from integration-tests/cypress/cypress.spec.js (Datadog) 
Cannot read properties of undefined (reading 'content')
View all

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ca413a1 | Docs | Was this helpful? Give us feedback!

BridgeAR
BridgeAR approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the tests!

@BridgeAR BridgeAR merged commit 54649d2 into master Aug 19, 2025
1001 of 1004 checks passed
@BridgeAR BridgeAR deleted the rachel.yang/telemetry-name-update branch August 19, 2025 09:34
dd-octo-sts bot pushed a commit that referenced this pull request Aug 19, 2025
@rachelyangdog @BridgeAR
fix: update telemetry name for truncated baggage (#6297)
bfacef4
@dd-octo-sts dd-octo-sts bot mentioned this pull request Aug 19, 2025
Merged
BridgeAR pushed a commit that referenced this pull request Aug 19, 2025
@rachelyangdog @BridgeAR
fix: update telemetry name for truncated baggage (#6297)
cae31e7
tlhunter pushed a commit that referenced this pull request Aug 22, 2025
@rachelyangdog @tlhunter
fix: update telemetry name for truncated baggage (#6297)
88430a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@ida613 ida613 Awaiting requested review from ida613

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachelyangdog @BridgeAR