test: remove withVersions global #6249
Conversation
This makes sure the withVersions helper is imported in all test files. That helps IDEs to show the description and allows to jump to the implementation. As drive-by, remove assert.doesNotThrow() and replace those with a comment. The call itself just adds CPU cycles and a comment should be fine as such.
Overall package sizeSelf size: 11.16 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.1.0 | 20.37 MB | 20.37 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6249 +/- ##
==========================================
+ Coverage 83.18% 83.63% +0.45%
==========================================
Files 445 468 +23
Lines 18808 19431 +623
==========================================
+ Hits 15645 16251 +606
- Misses 3163 3180 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-08-08 13:07:40 Comparing candidate commit f7f78f2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1273 metrics, 50 unstable metrics. |
| @@ -67,7 +67,8 @@ describe('PoissonProcessSamplingFilter', () => { | |||
| }) | |||
| assert.strictEqual(callCount, 1) | |||
| const event = { startTime: 0, duration: Number.POSITIVE_INFINITY } | |||
| assert.doesNotThrow(() => filter.filter(event)) | |||
| // Make sure that filtering events does not throw and calls now() once | |||
There was a problem hiding this comment.
I guess the net result is the same, but I personally prefer an explicit assertion. The fact that a comment is needed shows that the code is otherwise not clear.
There was a problem hiding this comment.
Soft agree, the assertion is only useful to make it explicit that this shouldn't throw. I'll survive if we remove them but not sure I'll remember to add comments like that.
There was a problem hiding this comment.
Any API call should theoretically be able to throw. It feels like we would need to wrap all our code into such things in that case.
There was a problem hiding this comment.
In those cases something else is asserted. But there are cases where the only thing the test does it to test whether it's throwing, although I guess at that point the test title could just reflect that.
This makes sure the withVersions helper is imported in all test files. That helps IDEs to show the description and allows to jump to the implementation. As drive-by, remove assert.doesNotThrow() and replace those with a comment. The call itself just adds CPU cycles and a comment should be fine as such.
This makes sure the withVersions helper is imported in all test files. That helps IDEs to show the description and allows to jump to the implementation. As drive-by, remove assert.doesNotThrow() and replace those with a comment. The call itself just adds CPU cycles and a comment should be fine as such.
This makes sure the withVersions helper is imported in all test files. That helps IDEs to show the description and allows to jump to the implementation. As drive-by, remove assert.doesNotThrow() and replace those with a comment. The call itself just adds CPU cycles and a comment should be fine as such.
This makes sure the withVersions helper is imported in all test files. That helps IDEs to show the description and allows to jump to the implementation.
As drive-by, remove assert.doesNotThrow() and replace those with a comment. The call itself just adds CPU cycles and a comment should be fine as such.