Skip to content

Conversation

rachelyangdog
Copy link
Contributor

What does this PR do?

  • Adding telemetry metrics for successful header injections and extractions for baggage
  • adding telemetry metrics for malformed baggage header extractions, and when max bytes or max item limits in baggage are exceeded
  • for more information: baggage telemetry RFC

Motivation

Plugin Checklist

Additional Notes

@rachelyangdog rachelyangdog requested a review from a team as a code owner July 28, 2025 18:27
@rachelyangdog rachelyangdog marked this pull request as draft July 28, 2025 18:27
Copy link

github-actions bot commented Jul 28, 2025

Overall package size

Self size: 11.12 MB
Deduped: 110.71 MB
No deduping: 111.09 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.1 | 20.3 MB | 20.3 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.14%. Comparing base (1f496ad) to head (cf30a0a).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6187      +/-   ##
==========================================
- Coverage   83.16%   83.14%   -0.03%     
==========================================
  Files         477      477              
  Lines       19722    19734      +12     
==========================================
+ Hits        16402    16407       +5     
- Misses       3320     3327       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rachelyangdog rachelyangdog requested a review from ida613 July 28, 2025 18:31
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 28, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cf30a0a | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Jul 28, 2025

Benchmarks

Benchmark execution time: 2025-07-29 21:01:44

Comparing candidate commit cf30a0a in PR branch rachel.yang/baggage-telemetry with baseline commit 1f496ad in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1271 metrics, 52 unstable metrics.

@rachelyangdog rachelyangdog changed the title WIP: add baggage telemetry add baggage telemetry Jul 28, 2025
@rachelyangdog rachelyangdog marked this pull request as ready for review July 28, 2025 19:12
@rachelyangdog rachelyangdog requested review from khanayan123 and removed request for khanayan123 July 29, 2025 20:54
Copy link
Collaborator

@ida613 ida613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending system tests

@rachelyangdog rachelyangdog merged commit 5875fec into master Jul 31, 2025
688 checks passed
@rachelyangdog rachelyangdog deleted the rachel.yang/baggage-telemetry branch July 31, 2025 17:20
dd-octo-sts bot pushed a commit that referenced this pull request Aug 1, 2025
@dd-octo-sts dd-octo-sts bot mentioned this pull request Aug 1, 2025
BridgeAR pushed a commit that referenced this pull request Aug 6, 2025
tlhunter pushed a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants