Skip to content

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jul 18, 2025

What does this PR do?

Removes asyncresource reference from sequelize

Motivation

Improve node 24 support

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Jul 18, 2025

Overall package size

Self size: 9.69 MB
Deduped: 109.27 MB
No deduping: 109.66 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.1 | 20.3 MB | 20.3 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (94afa6f) to head (df02a34).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6125      +/-   ##
==========================================
- Coverage   82.80%   82.37%   -0.44%     
==========================================
  Files         476      457      -19     
  Lines       19661    19073     -588     
==========================================
- Hits        16281    15712     -569     
+ Misses       3380     3361      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uurien uurien force-pushed the ugaitz/remove-asyncstorage-from-sequelize branch from d7ce93f to c7468f1 Compare July 18, 2025 13:15
@uurien uurien force-pushed the ugaitz/remove-asyncstorage-from-sequelize branch from c7468f1 to 98d78b2 Compare July 18, 2025 13:18
@pr-commenter
Copy link

pr-commenter bot commented Jul 18, 2025

Benchmarks

Benchmark execution time: 2025-07-22 15:34:12

Comparing candidate commit df02a34 in PR branch ugaitz/remove-asyncstorage-from-sequelize with baseline commit 94afa6f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1269 metrics, 54 unstable metrics.

@uurien uurien marked this pull request as ready for review July 21, 2025 07:52
@uurien uurien requested review from a team as code owners July 21, 2025 07:52
@uurien uurien marked this pull request as draft July 22, 2025 15:02
@uurien uurien marked this pull request as ready for review July 22, 2025 15:58
@uurien uurien enabled auto-merge (squash) July 22, 2025 16:03
@uurien uurien merged commit fe5bf31 into master Jul 22, 2025
992 of 1002 checks passed
@uurien uurien deleted the ugaitz/remove-asyncstorage-from-sequelize branch July 22, 2025 16:05
ghost pushed a commit that referenced this pull request Jul 22, 2025
@ghost ghost mentioned this pull request Jul 22, 2025
watson pushed a commit that referenced this pull request Jul 24, 2025
@IlyasShabi IlyasShabi mentioned this pull request Jul 29, 2025
58 tasks
tlhunter pushed a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants