Skip to content

[test-optimization] [SDTEST-2282] Add ci.job.id tag on supported CI providers #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

[test-optimization] [SDTEST-2282] Add ci.job.id tag on supported CI providers #6114

merged 1 commit into from
Jul 17, 2025

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented Jul 17, 2025 •
edited
Loading

What does this PR do?

This PR adds the ci.job.id tag for some of the CI providers that reports this data.

Motivation

Some of our users expected to have a ci.job.id.

Plugin Checklist

  • Unit tests.
  • Integration tests.

@github-actions GitHub Actions
Copy link

Overall package size

Self size: 9.68 MB
Deduped: 109.27 MB
No deduping: 109.65 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.0 | 20.3 MB | 20.31 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (9d0189a) to head (f2ae13a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6114   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files         475      475           
  Lines       19607    19608    +1     
=======================================
+ Hits        16234    16235    +1     
  Misses       3373     3373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mariovido Mariovido marked this pull request as ready for review July 17, 2025 11:05
@Mariovido Mariovido requested a review from a team as a code owner July 17, 2025 11:05
watson
watson reviewed Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a test for this?

@Mariovido
Copy link
Contributor Author

Mariovido commented Jul 17, 2025 •
edited
Loading

Shouldn't there be a test for this?

@watson We don't really need it as we already know that those env variables are populated, we might need to update datadog-ci-spec at some point (this will make possible to test it in the tracer), but it is not critical.

@watson
Copy link
Collaborator

watson commented Jul 17, 2025

According to CodeCov, a few of the changed lines in packages/dd-trace/src/plugins/util/ci.js are not covered by the unit tests. Do you happen to know if they are properly covered by integration tests?

@Mariovido
Copy link
Contributor Author

According to CodeCov, a few of the changed lines in packages/dd-trace/src/plugins/util/ci.js are not covered by the unit tests. Do you happen to know if they are properly covered by integration tests?

@watson We do test them through integration tests and through the use datadog-ci-spec and this test (test-environment.spec.js)

@Mariovido Mariovido merged commit 8efbffa into master Jul 17, 2025
960 of 961 checks passed
@Mariovido Mariovido deleted the mario.vidal/add_ci_job_id branch July 17, 2025 12:37
ghost pushed a commit that referenced this pull request Jul 18, 2025
@Mariovido @rochdev
[test-optimization] [SDTEST-2282] Add ci.job.id tag on supported CI…
0673e4a 
… providers (#6114)
@ghost ghost mentioned this pull request Jul 18, 2025
Merged
watson pushed a commit that referenced this pull request Jul 21, 2025
@Mariovido @watson
[test-optimization] [SDTEST-2282] Add ci.job.id tag on supported CI…
cc44290 
… providers (#6114)
tlhunter pushed a commit that referenced this pull request Aug 22, 2025
@Mariovido @tlhunter
[test-optimization] [SDTEST-2282] Add ci.job.id tag on supported CI…
cd86329 
… providers (#6114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

@calvinbayer calvinbayer calvinbayer approved these changes

Assignees
No one assigned
Labels
ci-app semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariovido @watson @calvinbayer