Skip to content

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented May 13, 2025

Fully support Node.js 24

@bengl bengl requested a review from a team as a code owner May 13, 2025 21:23
Copy link

github-actions bot commented May 13, 2025

Overall package size

Self size: 11.33 MB
Deduped: 110.98 MB
No deduping: 111.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.1.0 | 20.37 MB | 20.37 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.29%. Comparing base (3ecc436) to head (5ff4b04).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5726      +/-   ##
==========================================
- Coverage   83.32%   83.29%   -0.04%     
==========================================
  Files         478      478              
  Lines       19792    19792              
==========================================
- Hits        16492    16485       -7     
- Misses       3300     3307       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Report

Branch report: bengl/remove-acf-flag
Commit report: 80e6707
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 987 Passed, 0 Skipped, 21m 42.47s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • cypress@latest esm does not crash if badly init - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/cypress/cypress.spec.js)
    

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-08-08 21:00:29

Comparing candidate commit 5ff4b04 in PR branch bengl/remove-acf-flag with baseline commit 3ecc436 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1269 metrics, 54 unstable metrics.

@BridgeAR BridgeAR marked this pull request as draft May 14, 2025 14:04
@bengl bengl force-pushed the bengl/remove-acf-flag branch from 44d26c2 to dd515af Compare May 14, 2025 18:06
@bm1549 bm1549 removed the request for review from a team June 26, 2025 14:31
@szegedi szegedi force-pushed the bengl/remove-acf-flag branch from dd515af to 7f62e5f Compare July 1, 2025 08:23
@szegedi
Copy link
Contributor

szegedi commented Jul 1, 2025

Rebased locally to resolve merge conflicts.

@tlhunter
Copy link
Member

tlhunter commented Aug 7, 2025

Rebased locally, fixed conflicts, force pushed.

@tlhunter tlhunter force-pushed the bengl/remove-acf-flag branch from 2f6e844 to 5ff4b04 Compare August 8, 2025 20:52
@tlhunter tlhunter marked this pull request as ready for review August 8, 2025 20:52
@tlhunter tlhunter requested review from a team as code owners August 8, 2025 20:52
@tlhunter tlhunter mentioned this pull request Aug 8, 2025
58 tasks
@tlhunter tlhunter merged commit 2e40492 into master Aug 11, 2025
685 checks passed
@tlhunter tlhunter deleted the bengl/remove-acf-flag branch August 11, 2025 22:08
dd-octo-sts bot pushed a commit that referenced this pull request Aug 12, 2025
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
@dd-octo-sts dd-octo-sts bot mentioned this pull request Aug 12, 2025
szegedi pushed a commit that referenced this pull request Aug 18, 2025
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
tlhunter added a commit that referenced this pull request Aug 22, 2025
Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants