Skip to content

convert aws-sdk to runstores instead of asyncresource #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2025
Merged

convert aws-sdk to runstores instead of asyncresource #5707

merged 5 commits into from
Jul 29, 2025

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented May 12, 2025

What does this PR do?

Convert aws-sdk to runStores instead of AsyncResource.

Motivation

Otherwise it's broken on Node 24 as AsyncResource is broken.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 12, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c712ef4 | Was this helpful? Give us feedback!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 12, 2025 •
edited
Loading

Overall package size

Self size: 9.69 MB
Deduped: 109.27 MB
No deduping: 109.65 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.0.1 | 20.3 MB | 20.3 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov Codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (782a8e1) to head (c712ef4).
⚠️ Report is 44 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5707      +/-   ##
==========================================
- Coverage   82.81%   82.80%   -0.01%     
==========================================
  Files         476      476              
  Lines       19658    19659       +1     
==========================================
- Hits        16280    16279       -1     
- Misses       3378     3380       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rochdev rochdev force-pushed the aws-sdk-run-stores branch from 5462512 to 0e953bb Compare May 12, 2025 20:54
@pr-commenter
Copy link

pr-commenter bot commented May 12, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-07-21 21:22:42

Comparing candidate commit c712ef4 in PR branch aws-sdk-run-stores with baseline commit 782a8e1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1273 metrics, 50 unstable metrics.

@rochdev rochdev force-pushed the aws-sdk-run-stores branch from 0e953bb to 8a69df3 Compare June 13, 2025 19:43
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 13, 2025 •
edited
Loading

Datadog Report

Branch report: aws-sdk-run-stores
Commit report: 3a3af0f
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1258 Passed, 0 Skipped, 17m 23.16s Total Time

@tlhunter tlhunter mentioned this pull request Jul 3, 2025
Closed
58 tasks
@rochdev rochdev force-pushed the aws-sdk-run-stores branch from 3c2c562 to d3fa3ad Compare July 21, 2025 14:44
@rochdev rochdev marked this pull request as ready for review July 21, 2025 21:44
@rochdev rochdev requested review from a team as code owners July 21, 2025 21:44
wconti27
wconti27 reviewed Jul 28, 2025
View reviewed changes
wconti27
wconti27 reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@wconti27 wconti27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, thank you for this! Just had one question around the use of store.

@rochdev rochdev merged commit 1ec3e85 into master Jul 29, 2025
686 of 687 checks passed
@rochdev rochdev deleted the aws-sdk-run-stores branch July 29, 2025 16:27
dd-octo-sts bot pushed a commit that referenced this pull request Jul 30, 2025
@rochdev
convert aws-sdk to runstores instead of asyncresource (#5707)
4f7dc05
@dd-octo-sts dd-octo-sts bot mentioned this pull request Jul 30, 2025
Merged
BridgeAR pushed a commit that referenced this pull request Aug 6, 2025
@rochdev @BridgeAR
convert aws-sdk to runstores instead of asyncresource (#5707)
b74eae8
tlhunter pushed a commit that referenced this pull request Aug 22, 2025
@rochdev @tlhunter
convert aws-sdk to runstores instead of asyncresource (#5707)
c1b9e2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wconti27 wconti27 wconti27 approved these changes

Assignees
No one assigned
Labels
integration-aws-sdk semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rochdev @wconti27 @tlhunter