forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 0
Mainchain bmm (#4) #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add some tests * Add 4 prefix address and new deposit method * Add most of updated SCDB and deposit dialog * Update sidechain deposit validation * Update SCDB, rpc, deposits * Watch sidechain keys on startup * Remove unused function * Update comments / spacing * Add GetSidechainValues function * Update WT^ creation for B-WT^ * Update sidechain rpc calls * Reorganize, move non-db sidechain code to new file * Bug fix, add SCDB gethash, add check B-WT^ hash * Mainchain updates for BMM Add getbmmproof and createcriticalhashbribe rpc calls * build fix: include merkleblock.h * Refactoring / cleanup & fixes - Improve workscore & blocksremaining calculation when applying state script - Move ToString and other sidechain data type functions into the correct file - Rename SidechainVerification SidechainWTJoinState * Remove junk from testing * Add coinbase cache to chainactive * Refactoring: sidechaindb & validation * Add some updated tests * New unit test, spelling, bugs *Added multiple tau period unit test. *Fixed spelling errors *Add SCDB Sync() function (WIP) to sync with coinbase cache * BMM updates * Fix * Use CScript::serialize(300) for locktime in bribe script instead of 0x12c * BMM activation policy, other updates for OP_BRIBE * Update SCDB & SCDB unit tests
CryptAxe
pushed a commit
that referenced
this pull request
Aug 9, 2017
c521b3a Merge #11: fixup define checks. Cleans up some oopses from #5. 8b1cd37 fixup define checks. Cleans up some oopses from #5. 6b1508d Merge #6: Fixes typo fceb805 Merge #10: Clean up compile-time warnings (gcc 7.1) 0ec2a34 Clean up compile-time warnings (gcc 7.1) d4c268a Merge #5: Move helper functions out of sse4.2 object 8d4eb08 Add HasAcceleratedCRC32C to port_win.h 77cfbfd25 crc32: move helper functions out of port_posix_sse.cc 4c1e9e0 silence compiler warnings about uninitialized variables 4953164 Merge #2: Prefer std::atomic over MemoryBarrier 2953978 Fixes typo f134284 Merge #1: Merge upstream LevelDB 1.20 ba8a445 Prefer std::atomic over MemoryBarrier git-subtree-dir: src/leveldb git-subtree-split: c521b3a
CryptAxe
pushed a commit
that referenced
this pull request
Aug 9, 2017
b13a68e Squashed 'src/leveldb/' changes from 196962f..c521b3a (Pieter Wuille) Pull request description: Includes: * bitcoin-core/leveldb-subtree#2: Prefer std::atomic over MemoryBarrier (Pieter Wuille) * bitcoin-core/leveldb-subtree#5: Move helper functions out of sse4.2 object (Cory Fields) * bitcoin-core/leveldb-subtree#6: Fixes typo (Dimitris Tsapakidis) * bitcoin-core/leveldb-subtree#10: Clean up compile-time warnings (gcc 7.1) (Matt Corallo) * bitcoin-core/leveldb-subtree#11: fixup define checks. Cleans up some oopses from #5 (Cory Fields) Tree-SHA512: 2b88a99a86ed8c74c860de13a123ea7f5424d35d314be564820cf83aaae8308383403f7cd56f17c241cfee4885699796141fed666559c21044eaabaeea073315
CryptAxe
pushed a commit
that referenced
this pull request
Feb 13, 2018
CryptAxe
pushed a commit
that referenced
this pull request
Feb 15, 2018
Sync with upstream again, minor refactoring
CryptAxe
pushed a commit
that referenced
this pull request
Feb 13, 2020
6f53edb Acquire cs_main before ATMP call in block_assemble bench (James O'Beirne) Pull request description: Calling `bench_bitcoin` currently fails due to calling ATMP without acquiring cs_main first in the recently added block_assemble bench (bitcoin#13219). ``` $ cat <(uname -a) <(gcc --version) Linux james 4.4.0-119-generic bitcoin#143+jamesob SMP Mon Apr 16 21:47:24 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 $ ./src/bench/bench_bitcoin WARNING: This is a debug build - may result in slower benchmarks. # Benchmark, evals, iterations, total, min, max, median Assertion failed: lock cs_main not held in validation.cpp:566; locks held: [1] 19323 abort (core dumped) ./src/bench/bench_bitcoin ``` ``` (gdb) bt #0 0x00007fbdc9cf5428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x00007fbdc9cf702a in __GI_abort () at abort.c:89 #2 0x0000555a19580dc5 in AssertLockHeldInternal (pszName=pszName@entry=0x555a19834549 "cs_main", pszFile=pszFile@entry=0x555a1988a001 "validation.cpp", nLine=nLine@entry=566, cs=cs@entry=0x555a19ba55c0 <cs_main>) at sync.cpp:157 #3 0x0000555a194b395f in AcceptToMemoryPoolWorker (chainparams=..., pool=..., state=..., ptx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=1532964079, plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=@0x7ffcbc1719d8: 0, coins_to_uncache=std::vector of length 0, capacity 0, test_accept=false) at validation.cpp:566 #4 0x0000555a194ba661 in AcceptToMemoryPoolWithTime (chainparams=..., pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=<optimized out>, plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=0, test_accept=false) at validation.cpp:998 #5 0x0000555a194ba7ce in AcceptToMemoryPool (pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, plTxnReplaced=plTxnReplaced@entry=0x0, bypass_limits=bypass_limits@entry=false, nAbsurdFee=0, test_accept=false) at validation.cpp:1014 #6 0x0000555a19363fbe in AssembleBlock (state=...) at bench/block_assemble.cpp:102 #7 0x0000555a193654d3 in std::_Function_handler<void (benchmark::State&), void (*)(benchmark::State&)>::_M_invoke(std::_Any_data const&, benchmark::State&) (__functor=..., __args#0=...) at /usr/include/c++/5/functional:1871 #8 0x0000555a193501d7 in std::function<void (benchmark::State&)>::operator()(benchmark::State&) const (this=this@entry=0x555a1ba2cda0, __args#0=...) at /usr/include/c++/5/functional:2267 #9 0x0000555a1934ec4c in benchmark::BenchRunner::RunAll (printer=..., num_evals=5, scaling=<optimized out>, filter=..., is_list_only=false) at bench/bench.cpp:121 #10 0x0000555a1934ade9 in main (argc=<optimized out>, argv=<optimized out>) at bench/bench_bitcoin.cpp:92 ``` Tree-SHA512: fdd7b28ff123ccea7a4f334d53f735d0c0f94aa9cc52520c2dd34dca45d78c691af64efcd32366fc472fedffbd79591d2be2bb3bfc4a5186e8712b6b452d64e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests
Add 4 prefix address and new deposit method
Add most of updated SCDB and deposit dialog
Update sidechain deposit validation
Update SCDB, rpc, deposits
Watch sidechain keys on startup
Remove unused function
Update comments / spacing
Add GetSidechainValues function
Update WT^ creation for B-WT^
Update sidechain rpc calls
Reorganize, move non-db sidechain code to new file
Bug fix, add SCDB gethash, add check B-WT^ hash
Mainchain updates for BMM
Add getbmmproof and createcriticalhashbribe rpc calls
build fix: include merkleblock.h
Refactoring / cleanup & fixes
Improve workscore & blocksremaining calculation when applying state script
Move ToString and other sidechain data type functions into the correct file
Rename SidechainVerification SidechainWTJoinState
Remove junk from testing
Add coinbase cache to chainactive
Refactoring: sidechaindb & validation
Add some updated tests
New unit test, spelling, bugs
*Added multiple tau period unit test.
*Fixed spelling errors
*Add SCDB Sync() function (WIP) to sync with coinbase cache
BMM updates
Fix
Use CScript::serialize(300) for locktime in bribe script instead of 0x12c
BMM activation policy, other updates for OP_BRIBE
Update SCDB & SCDB unit tests