Move Pods Project Generation into an Xcode namespace #5480
Conversation
|
|
||
| Pod::Xcode::PodsProjectGenerator.any_instance.stubs(:generate!) | ||
| Pod::Xcode::PodsProjectGenerator.any_instance.stubs(:share_development_pod_schemes) | ||
| Pod::Xcode::PodsProjectGenerator.any_instance.stubs(:write) do |
There was a problem hiding this comment.
@segiddins I don't think this is the right way to stub this, do you know of a better way?
There was a problem hiding this comment.
just stub it and check @hook_called at the end of the spec?
4b6fe2c to
fd65c0f
Compare
| private | ||
|
|
||
| def create_generator | ||
| Pod::Xcode::PodsProjectGenerator.new(aggregate_targets, sandbox, pod_targets, analysis_result, installation_options, config) |
fd65c0f to
e0e7680
Compare
|
@dantoml the diff here is massive -- can you point us towards stuff you feel needs review (versus the stuff that's copy/pasted?) |
|
@segiddins Yeah, just working on fixing the build then will point to the changes 👍 |
816328d to
4cbf0c6
Compare
| UI.section 'Generating Pods project' do | ||
| prepare_pods_project |
There was a problem hiding this comment.
The changes here maintain the previous method call ordering, but inside PodsProjectGenerator
| @@ -0,0 +1,393 @@ | |||
| module Pod | |||
There was a problem hiding this comment.
This was moved into the Xcode namespace
Danger was crashing CocoaPods#5480 before I added a changelog entry because `pr` was undefined. From looking at Danger, it seems that this should be `pr_title`?
| @@ -14,6 +14,9 @@ Documentation: | |||
|
|
|||
| #- CocoaPods -----------------------------------------------------------------# | |||
|
|
|||
| ParameterLists: | |||
There was a problem hiding this comment.
did you update this in the Shared repo as well?
There was a problem hiding this comment.
I moved this from .rubocop.yml because it was conflicting with .rubocop_todo.yml, where else should it be updated?
There was a problem hiding this comment.
There was a problem hiding this comment.
Shared PR CocoaPods/shared#7
70dc601 to
f7cee5e
Compare
* Fix Dangerfile Rubocop violations * Update CHANGELOG.md * Update docs * Don't use Type = Type::Type in tests
f7cee5e to
7646e92
Compare
|
So is this basically ready to merge, or is there anything that requires review? |
|
@segiddins I think this is ready to merge now. |
| # | ||
| # @return [void] | ||
| # | ||
| def create_dummy_source |
There was a problem hiding this comment.
@endocrimes it's a long time past, do you still remember the reason for create the dummy files .
Relates to #2729
Subsequent PRs will move the installer into a base installer and Xcode::Installer, then a Rome installer.