[XCConfigHelper] Add the ability to inhibit swift warnings #5414
Conversation
|
I'm assuming I will have to add a Changelog comment, correct? |
|
Please, you can see the format in this PR: #5413 |
| '$(inherited)', | ||
| quote(%w(-D COCOAPODS)), | ||
| (quote(%w(-suppress-warnings)) if target.try(:inhibit_warnings?) || false), | ||
| ].compact.join(' '), |
There was a problem hiding this comment.
Why not make an array var for the flags and conditionally append to it?
There was a problem hiding this comment.
I'm good with that. Then we don't need to compact
| 'OTHER_SWIFT_FLAGS' => '$(inherited) ' + quote(%w(-D COCOAPODS)), | ||
| } | ||
| other_swift_flags = ['$(inherited)', quote(%w(-D COCOAPODS))] | ||
| other_swift_flags += [quote(%w(-suppress-warnings))] if target.try(:inhibit_warnings?) |
There was a problem hiding this comment.
can be other_swift_flags << quote(%w(-suppress-warnings)) if target.inhibit_warnings?
|
👍 with test |
|
@segiddins, when I run the tests using rake, I get 46 failures, and they all look like missing double quotes, which obviously, I did not cause. They were failing even before my commits. What kind of environment do I need to get it to run properly? I am using
Also, all the unit tests pass and all the errors happen in the integration tests. |
|
@pRizz don't worry about those |
|
It should be good now 👍 |
|
@mrackwitz look good to you? |
|
LGTM 👍 |
|
Bump |
|
🎉 |
This PR adds the ability to inhibit swift warnings for pod targets. This is related to issue 5290.
Even without my changes, many unit tests fail locally. Why is that?