fix: use default disk.columns when only other disk.* configs exist #1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I configured `[disk.name_filter]` and after upgrading to v0.11.0, the disk widget became empty since `disk.columns` was parsed as an empty vector unless I added `disk.columns` to my config as well.
f966d1e to
de5de55
Compare
ClementTsang
approved these changes
Aug 8, 2025
|
Thanks for fixing this! I'll add to the changelog in a bit and get it out in the next few days. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
==========================================
- Coverage 53.60% 53.55% -0.06%
==========================================
Files 115 115
Lines 16030 16035 +5
==========================================
- Hits 8593 8587 -6
- Misses 7437 7448 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 16, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [ClementTsang/bottom](https://github.com/ClementTsang/bottom) | patch | `0.11.0` -> `0.11.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>ClementTsang/bottom (ClementTsang/bottom)</summary> ### [`v0.11.1`](https://github.com/ClementTsang/bottom/blob/HEAD/CHANGELOG.md#0111---2025-08-15) [Compare Source](ClementTsang/bottom@0.11.0...0.11.1) ##### Bug Fixes - [#​1776](ClementTsang/bottom#1776): Fix `disk.columns` being incorrectly interpreted as blank. - [#​1787](ClementTsang/bottom#1787): Fix issue with battery widget time and small widths. ##### Other - [#​1779](ClementTsang/bottom#1779), [#​1788](ClementTsang/bottom#1788): Speed up time between startup and displaying data. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS43MS4wIiwidXBkYXRlZEluVmVyIjoiNDEuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
de5de558fix: use default disk.columns when only other disk.* configs existI configured
[disk.name_filter]and after upgrading to v0.11.0, thedisk widget became empty since
disk.columnswas parsed as an emptyvector unless I added
disk.columnsto my config as well.Issue
N/A
Testing
If relevant, please state how this was tested. All changes must be tested to work:
Using a config like:
v0.11.0 renders an empty disk widget. This PR uses the default disk
widget columns.
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)