feat: add option to move avg CPU to another row #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passes for the most part, the only failures are codecov ratelimiting |
|
Sorry for the delay - I'll look at it by the weekend.
Yep, that's fine. |
be2d466 to
7b5b06b
Compare
7b5b06b to
afe4163
Compare
|
Rebased to resolve merge conflicts |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
- Coverage 41.27% 36.81% -4.46%
==========================================
Files 113 93 -20
Lines 17739 16087 -1652
==========================================
- Hits 7321 5923 -1398
+ Misses 10418 10164 -254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClementTsang
requested changes
Aug 1, 2024
Adds an `average_cpu_row` option to move the average CPU usage to its own row when using basic mode.
afe4163 to
9253aaa
Compare
|
Rebased and addressed feedback |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 10, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [ClementTsang/bottom](https://github.com/ClementTsang/bottom) | patch | `0.10.1` -> `0.10.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>ClementTsang/bottom (ClementTsang/bottom)</summary> ### [`v0.10.2`](https://github.com/ClementTsang/bottom/blob/HEAD/CHANGELOG.md#0102---2024-08-05) [Compare Source](ClementTsang/bottom@0.10.1...0.10.2) ##### Features - [#​1487](ClementTsang/bottom#1487): Add option to move the AVG CPU bar to another row in basic mode. ##### Bug Fixes - [#​1541](ClementTsang/bottom#1541): Fix some process details not updating for macOS and Windows. - [#​1542](ClementTsang/bottom#1542): Fix confusing process run times being reported on macOS. - [#​1543](ClementTsang/bottom#1543): Fix the `--default_cpu_entry` argument not being checked. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
average_cpu_rowoption to move the average CPU usage to its own row when using basic mode.Issue
I didn't make an issue for this, I did this for myself but thought I might as well try to upstream.
Testing
Tested by turning on and off the new layout via cli flag and config file entry and ensuring the layout was rendered accordingly.
Checklist
cargo fmt)README.md, help menu, doc pages, etc.)