Skip to content

Make StringBuilder follow the protocol of IDisposable. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2021
Merged

Make StringBuilder follow the protocol of IDisposable. #43

merged 1 commit into from
Apr 6, 2021

Conversation

udaken
Copy link
Contributor

@udaken udaken commented Feb 28, 2021

IDisposable requires the following.

If an object's Dispose method is called more than once, the object must ignore all calls after the first one. The object must not throw an exception if its Dispose method is called multiple times.

Utf16ValueStringBuilder and Utf8ValueStringBuilder are now throwing exceptions and have been fixed.

@neuecc
Copy link
Member

neuecc commented Apr 6, 2021

absolutely right, thanks!

@neuecc neuecc merged commit 12c0c1d into Cysharp:master Apr 6, 2021
@udaken udaken deleted the make-StringBuilder-follow-the-protocol-of-IDisposable branch April 6, 2021 07:19
ThangwLee pushed a commit to WolffunGame/ZString that referenced this pull request May 26, 2023
@neuecc
Merge pull request Cysharp#43 from udaken/make-StringBuilder-follow-t…
294ba23 
…he-protocol-of-IDisposable

Make StringBuilder follow the protocol of IDisposable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udaken @neuecc