Skip to content

Improved performance of StringBuilder.AppendFormat #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 3, 2020
Merged

Improved performance of StringBuilder.AppendFormat #27

merged 15 commits into from
Aug 3, 2020

Conversation

udaken
Copy link
Contributor

@udaken udaken commented Aug 1, 2020 •
edited
Loading

StringBuilder.AppendFormat expands to a large code size.

Duplicate code is generated if the same type argument is used.

Large codes are probably not good for JITs.

Performance can be improved by reducing the code size. It can be up to 20% faster.
(Depends on the type arguments used and the number of type arguments.)

Please try running BenchmarkVsReleasedVersion project in your environment.

BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19042
AMD Ryzen 7 3700X, 1 CPU, 16 logical and 8 physical cores
.NET Core SDK=3.1.302
  [Host]   : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT
  ShortRun : .NET Core 3.1.6 (CoreCLR 4.700.20.26901, CoreFX 4.700.20.31603), X64 RyuJIT

Job=ShortRun  IterationCount=1  LaunchCount=1  
WarmupCount=1

MaximumArgsFormatBenchmark

Method Mean Error Ratio Gen 0 Gen 1 Gen 2 Allocated Code Size
Format_ 1,494.6 ns NA 1.00 0.0477 - - 400 B 13720 B
FormatN 1,232.2 ns NA 0.82 0.0477 - - 400 B 4564 B
CreatePreparedFormat_ 1,435.9 ns NA 1.00 0.6256 0.0095 - 5240 B 2796 B
CreatePreparedFormatN 1,413.7 ns NA 0.98 0.6256 0.0095 - 5240 B 2796 B
Utf16PreparedFormat_ 825.7 ns NA 1.00 0.0477 - - 400 B 15688 B
Utf16PreparedFormatN 830.9 ns NA 1.01 0.0467 - - 392 B 15791 B
Utf8PreparedFormat_ 908.3 ns NA 1.00 0.0477 - - 400 B 16485 B
Utf8PreparedFormatN 900.5 ns NA 0.99 0.0477 - - 400 B 16589 B
Utf16StringBuilderAppendFormat_ 1,479.1 ns NA 1.00 - - - - 17875 B
Utf16StringBuilderAppendFormatN 1,196.1 ns NA 0.81 - - - - 8681 B
Utf8StringBuilderAppendFormat_ 1,822.2 ns NA 1.00 - - - - 19491 B
Utf8StringBuilderAppendFormatN 1,430.5 ns NA 0.79 - - - - 9241 B

udaken added 15 commits July 8, 2020 20:14
@udaken
Built-in support for IntPtr/UIntPtr
8cfd48b
@udaken
Built-in support for Nullable<T>
369667c
@udaken
Fallback if IFormattable is supported
f14f536
@udaken
Optimize ZString.Join(IReadOnlyList<T>)
2c05982
@udaken
Add StringBuilder.AppendJoin
351d4a7
@udaken
update README.md
6a301ba
@udaken
Merge remote-tracking branch 'remotes/origin/master' into add-StringB…
e94d2ab 
…uilder-AppendJoin

fixed the conflict with Cysharp#22.
@udaken
Merge remote-tracking branch 'remotes/origin/master' into Built-in-su…
f546e27 
…pport-for-IntPtr-UIntPtr
@udaken
Merge branch 'add-StringBuilder-AppendJoin'
38ee841
@udaken
ReRun T4 Text Templates Tool on VS2019(16.6.5)
655c360
@udaken
Code cleanup
1ff7e56
@udaken
Make ignored BenchmarkDotNet Results
ae8b646
@udaken
Bump up BenchmarkDotNet to v0.12.1
e1780cc
@udaken
Add BenchmarkVsReleasedVersion project
03e0f4a
@udaken
Improved performance of StringBuilder.AppendFormat
6919046
@udaken
Copy link
Contributor Author

udaken commented Aug 1, 2020

This branch has already merged #21 and #24 .

@neuecc neuecc merged commit ed2a994 into Cysharp:master Aug 3, 2020
@udaken udaken deleted the Improved-performance-of-StringBuilder.AppendFormat branch August 3, 2020 15:08
ThangwLee pushed a commit to WolffunGame/ZString that referenced this pull request May 26, 2023
@neuecc
Merge pull request Cysharp#27 from udaken/Improved-performance-of-Str…
3030b90 
…ingBuilder.AppendFormat

Improved performance of StringBuilder.AppendFormat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udaken @neuecc