Skip to content

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Jun 29, 2025

This PR fixes 2 issues:

  1. MVN_ARGS param was unused when calculating parent component, added usage for it as well. (Solves issue MVN_ARGS env var unused when calculating first pom parent #2007)
  2. Recently a validator to server parameters was added, but there was no support to boolean values which was previously expected. I've encountered it when fixing the first issue and added a fix for it as well.

bo156 added 2 commits June 29, 2025 15:22
…mponent

Signed-off-by: Barak Fatal <barakf156@gmail.com>
Signed-off-by: Barak Fatal <barakf156@gmail.com>
@bo156 bo156 force-pushed the bugfix/mvn-first-pom-mvnArgs-usage branch from 9a0af4c to 696f490 Compare June 29, 2025 12:23
Copy link
Collaborator

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@prabhu
Copy link
Collaborator

prabhu commented Jun 30, 2025

@malice00 how can we improve the git clone command to make it work for external PRs in the binary builds workflow?

@prabhu prabhu merged commit 1a4b7d1 into CycloneDX:master Jun 30, 2025
121 of 124 checks passed
malice00 pushed a commit that referenced this pull request Jul 1, 2025
…n to server to get boolean values (#2006)

* Add mvnArgs params to first mvn command when trying to find parent component

Signed-off-by: Barak Fatal <barakf156@gmail.com>

* Added back option to pass boolean as parameter to cdxgen server

Signed-off-by: Barak Fatal <barakf156@gmail.com>

---------

Signed-off-by: Barak Fatal <barakf156@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants