Skip to content

#1974 add js e2e tests using pg driver #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 13, 2025
Merged

#1974 add js e2e tests using pg driver #1975

merged 8 commits into from
Feb 13, 2025

Conversation

robfrank
Copy link
Collaborator

What does this PR do?

Adds e2e tests written in JS using the PG driver and Testcontainers

Motivation

To avoid regressions with JS PG driver

Related issues

#1956

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank added this to the 25.2.1 milestone Feb 13, 2025
@robfrank robfrank self-assigned this Feb 13, 2025
@codacy-production Codacy Production
Copy link

codacy-production bot commented Feb 13, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 06658771 ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0665877) Report Missing Report Missing Report Missing
Head commit (bb0a454) 68451 43980 64.25%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1975) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@ExtReMLapin ExtReMLapin mentioned this pull request Feb 13, 2025
Merged
lvca
lvca reviewed Feb 13, 2025
View reviewed changes
gremlin/src/test/java/com/arcadedb/server/gremlin/AbstractGremlinServerIT.java Outdated
@@ -55,7 +55,7 @@ public void setTestConfiguration() {
FileUtils.readStreamAsString(getClass().getClassLoader().getResourceAsStream("gremlin-server.groovy"), "utf8"));

GlobalConfiguration.SERVER_PLUGINS.setValue("GremlinServer:com.arcadedb.server.gremlin.GremlinServerPlugin");

GlobalConfiguration.TYPE_DEFAULT_BUCKETS.setValue(8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me remove this and open another PR for IT tests

@robfrank robfrank force-pushed the feature/1974-add-js-pg-tests branch from 6090b82 to d97ce92 Compare February 13, 2025 14:07
lvca
lvca reviewed Feb 13, 2025
View reviewed changes
server/src/test/java/com/arcadedb/server/StaticBaseServerTest.java Outdated
@@ -40,6 +40,7 @@ public void setTestConfiguration() {
GlobalConfiguration.SERVER_ROOT_PATH.setValue("./target");
GlobalConfiguration.SERVER_ROOT_PASSWORD.setValue(DEFAULT_PASSWORD_FOR_TESTS);
GlobalConfiguration.SERVER_HTTP_IO_THREADS.setValue(2);
GlobalConfiguration.TYPE_DEFAULT_BUCKETS.setValue(8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here :-)

@robfrank robfrank changed the title #1974 add js e2e tests #1974 add js e2e tests using pg driver Feb 13, 2025
@robfrank robfrank merged commit 42726c4 into main Feb 13, 2025
3 of 6 checks passed
@robfrank robfrank deleted the feature/1974-add-js-pg-tests branch June 20, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca lvca left review comments

Assignees

@robfrank robfrank

Labels
None yet
Projects
None yet
Milestone
25.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@robfrank @lvca