Skip to content

Conversation

robfrank
Copy link
Collaborator

What does this PR do?

Motivation

After replacing ByteBuffer with Binary on the PG plugin, the JS driver is unable to fetch the result of a query.

Related issues

#1956

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

Copy link

codacy-production bot commented Feb 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% 58.62%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f040dff) 68469 43993 64.25%
Head commit (9109a25) 68451 (-18) 43991 (-2) 64.27% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1959) 116 68 58.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@robfrank robfrank force-pushed the fix/1956-pgsql-endopint-js-driver branch from 9af88bc to 9109a25 Compare February 12, 2025 21:25
@robfrank robfrank marked this pull request as ready for review February 13, 2025 07:59
@robfrank robfrank added the bug Something isn't working label Feb 13, 2025
@robfrank robfrank added this to the 25.2.1 milestone Feb 13, 2025
@robfrank robfrank changed the title #1956 preliminary work on PG endpoint #1956 fix PGSQL when used with JS/npm pg driver Feb 13, 2025
@robfrank robfrank merged commit 491192c into main Feb 13, 2025
8 of 11 checks passed
@robfrank robfrank deleted the fix/1956-pgsql-endopint-js-driver branch June 20, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed / implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant