Skip to content

chore: more java17 idiomatic code #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2024
Merged

chore: more java17 idiomatic code #1806

merged 4 commits into from
Nov 5, 2024

Conversation

robfrank
Copy link
Collaborator

@robfrank robfrank commented Nov 1, 2024

What does this PR do?

Chore PR: more java17 compliant code

Motivation

to java 17 and beyond

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@codacy-production Codacy Production
Copy link

codacy-production bot commented Nov 1, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.02% ✅ 71.83%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ba1ba1d) 68823 44204 64.23%
Head commit (3f049da) 68795 (-28) 44203 (-1) 64.25% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1806) 323 232 71.83%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@robfrank robfrank force-pushed the improvement/0000-chore branch from 155ecd0 to 4af8c95 Compare November 1, 2024 19:05
@lvca lvca self-requested a review November 1, 2024 23:21
@lvca lvca added this to the 24.11.1 milestone Nov 1, 2024
@lvca lvca added the enhancement New feature or request label Nov 1, 2024
@robfrank robfrank force-pushed the improvement/0000-chore branch 2 times, most recently from fb21033 to 6bf8400 Compare November 3, 2024 13:42
@robfrank robfrank marked this pull request as ready for review November 3, 2024 13:44
@lvca
Copy link
Contributor

lvca commented Nov 3, 2024

I see many changes are just formatting, like:

 if (ov != null)
          neighbors.add(ov);

into

 if (ov != null) neighbors.add(ov);

I think it's not Java17, that your formatting setting :-)

@robfrank
add some tests
13ccc3e 
general cleanup for more java17 idiomatic
@robfrank robfrank force-pushed the improvement/0000-chore branch from 6bf8400 to 13ccc3e Compare November 4, 2024 17:14
@mergify mergify bot merged commit c9d22c5 into main Nov 5, 2024
9 of 12 checks passed
@robfrank robfrank deleted the improvement/0000-chore branch June 20, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca lvca approved these changes

Assignees

@robfrank robfrank

Labels
enhancement New feature or request
Projects
None yet
Milestone
24.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@robfrank @lvca