Skip to content

Conversation

jshier
Copy link
Contributor

@jshier jshier commented May 10, 2023

Issue Link πŸ”—

#3719

Goals ⚽

Unfortunately the deployment changes were more breaking than expected so this PR reverts them. Anyone having issues with libarclite should manually set their deployment target using a post_install hook, but that issue is much less common than this deployment target issue.

@jshier jshier added this pull request to the merge queue May 10, 2023
Merged via the queue into master with commit 236844f May 10, 2023
@jshier jshier deleted the revert-deployment-target-change branch May 10, 2023 15:46
@jshier jshier added this to the 5.7.1 milestone May 10, 2023
@crsantos
Copy link

Hello,

Unfortunately the deployment changes were more breaking than expected

I'm afraid that this is fixed with a post_install for everyone that uses Alamofire as a dependency on a Podfile.

But this is not the same as having a pod with a dependency on it, as cocoapods needs to lint the spec, and iOS 10 is one of the deployment targets that is not valid on Xcode 14.3 anymore, every single pod lib lint will fail, as it needs iOS 11.0 and beyond, like you can see on this PR discussion: mxcl/PromiseKit#1318 (comment)

So we have a chicken and egg problem here πŸ˜…

Could a major version fix this? And we can finally drop iOS 10?

@jshier
Copy link
Contributor Author

jshier commented Jun 12, 2023

iOS 10 (and that generation) is still valid, it just produces a warning, unlike iOS 8. For integrators, the post_install hook can take care of that, and for libraries with dependencies, passing --allow-warnings allows linting and pushing to pass normally with no changes to the pod itself. Any dependent library can also set its deployment target to any higher value, so Alamofire being low isn't a limitation.

The simple fact of the matter is that Apple will keep arbitrarily updating the minimum supported deployment target in Xcode whenever they want, and doing a major release to match every time that happens isn't tenable. If there's an actual breaking change, not simply a CocoaPod issue, then a major release may make sense.

@crsantos
Copy link

Thank you so much for confirming @jshier, that's true, and I confirmed here with a lint, it's indeed a warning.

Let me get from here πŸ˜„

@jshier jshier mentioned this pull request Aug 22, 2023
prongbang pushed a commit to prongbang/Alamofire that referenced this pull request May 23, 2025
### Issue Link πŸ”—
Alamofire#3719

### Goals ⚽
Unfortunately the deployment changes were more breaking than expected so
this PR reverts them. Anyone having issues with libarclite should
manually set their deployment target using a `post_install` hook, but
that issue is much less common than this deployment target issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants