Skip to content

Fixed archive errors on watchOS #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Fixed archive errors on watchOS #3112

merged 2 commits into from
Mar 15, 2020

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for Alamofire.
In this pull request I fixed the issue mentioned in #3083 (comment).

Goals ⚽

Fixed Alamofire installation via Carthage.

Implementation Details 🚧

Reverted changes from e02ea43.

Testing Details 🔍

Product -> Archive works fine for all targets.

Copy link
Contributor

@jshier jshier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good, but we still need the CFNetwork linking, so please add that back.

@jshier jshier merged commit c5b1e47 into Alamofire:master Mar 15, 2020
@jshier jshier added this to the 5.0.4 milestone Mar 15, 2020
@jshier
Copy link
Contributor

jshier commented Mar 15, 2020

This was released as part of 5.0.4.

prongbang pushed a commit to prongbang/Alamofire that referenced this pull request May 23, 2025
* Removed OTHER_LDFLAGS for watchOS

* Removed OTHER_LDFLAGS for watchOS when installing via CocoaPods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants