feat(command): add commandWaitId support #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Aug 5, 2025
- Add CommandWaitIdCapable interface to CommandResult
- Update CommandMessage to include commandWaitId in sentSignal
- Modify sendAndWait methods to accept commandWaitId parameter
- Update CommandWaitNotifier to use commandWaitId for local command check
- Adjust CommandWaitStrategyRegistrar to use commandWaitId for registration
- Update WaitingForStage to include commandWaitId in materialized form
- Modify related tests to accommodate new commandWaitId functionality
- Add CommandWaitIdCapable interface to CommandResult - Update CommandMessage to include commandWaitId in sentSignal - Modify sendAndWait methods to accept commandWaitId parameter - Update CommandWaitNotifier to use commandWaitId for local command check - Adjust CommandWaitStrategyRegistrar to use commandWaitId for registration - Update WaitingForStage to include commandWaitId in materialized form - Modify related tests to accommodate new commandWaitId functionality Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
============================================
- Coverage 91.23% 91.11% -0.13%
- Complexity 3716 3720 +4
============================================
Files 702 702
Lines 12827 12866 +39
Branches 817 818 +1
============================================
+ Hits 11703 11723 +20
- Misses 737 752 +15
- Partials 387 391 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ahoo-Wang
added a commit
that referenced
this pull request
Aug 5, 2025
Ahoo-Wang
added a commit
that referenced
this pull request
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.