Skip to content

Changelog for version 1.3.5 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 12, 2023
Merged

Changelog for version 1.3.5 #359

merged 10 commits into from
Jun 12, 2023

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented May 10, 2023 •
edited
Loading

Changelog for version 1.3.5.

TODO:

  • Define version number in CHANGELOG.md, add release date and update links
  • Add same version number in defines.php
  • Assign a milestone corresponding to the version number to this PR and PRs that will form the release
  • Assign label (changelog)
  • Run unit-test suite
  • Run integration-test suite with secrets
  • Manual testing
    • Pull request with PHP linting issues
    • Pull request with PHPCS issues
    • Pull request without PHPCS issues, not auto-approved
    • Pull request without PHPCS issues, is auto-approved
    • Pull request with SVG issues
    • Pull request with large file to be skipped
    • Pull request with plugins and themes to be scanned via WPScan API

@gudmdharalds gudmdharalds added this to the 1.3.5 milestone May 10, 2023
@gudmdharalds gudmdharalds mentioned this pull request May 10, 2023
Merged
6 tasks
wpcomvip-vipgoci-bot
wpcomvip-vipgoci-bot previously approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved pull request #359 as it contains only auto-approvable files -- non-functional changes to PHP files or file-types that are auto-approvable (css, csv, eot, gif, gz, ico, ini, jpeg, jpg, json, less, map, md, mdown, mo, mp4, otf, pcss, pdf, po, pot, png, sass, scss, styl, ttf, txt, woff, woff2, yml).

@gudmdharalds gudmdharalds mentioned this pull request May 10, 2023
Merged
3 tasks
This was referenced May 12, 2023
Merged
Merged
@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review May 25, 2023 18:36

Dismissing obsolete review; not approved any longer

@gudmdharalds gudmdharalds mentioned this pull request Jun 12, 2023
Merged
4 tasks
@gudmdharalds gudmdharalds mentioned this pull request Jun 12, 2023
Merged
4 tasks
@wpcomvip-vipgoci-bot
Copy link
Collaborator

No issues were found to report when scanning latest commit (commit-ID: 2790682)

This bot provides automated PHP linting, PHPCS scanning and Vulnerability and Update Scan. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions

  • vip-go-ci version: 1.3.4
  • PHP runtime version for vip-go-ci: 8.1.20
  • PHP runtime for linting:
    • PHP 8.1: 8.1.20
  • PHP runtime version for PHPCS: 7.4.33
  • PHPCS version: 3.7.1
  • PHP runtime version for SVG scanner: 7.4.33

Options file (.vipgoci_options)

Options file enabled: true

Configurable options:

  • skip-execution
  • skip-draft-prs
  • lint-modified-files-only
  • phpcs
  • phpcs-severity
  • phpcs-sniffs-include
  • phpcs-sniffs-exclude
  • report-no-issues-found
  • review-comments-sort
  • review-comments-include-severity
  • post-generic-pr-support-comments
  • review-comments-sort
  • scan-details-msg-include
  • svg-checks
  • autoapprove
  • autoapprove-php-nonfunctional-changes

Options altered:

  • phpcs-severityset to1
  • phpcs-sniffs-includeset toGeneric.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode
  • phpcs-sniffs-excludeset toWordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax
  • skip-draft-prsset to

PHP lint options

PHP lint files enabled: true

Lint modified files only: true

Lint files with file extensions:

  • php

Directories not PHP linted:

  • None

SVG configuration

SVG scanning enabled: true

Scan added/modified files with file extensions:

  • svg

Auto-approval configuration

Auto-approvals enabled: true

Non-functional changes auto-approved: true

Files with file extensions to consider for non-functional change auto-approval: php

Auto-approved file-types:

  • css
  • csv
  • eot
  • gif
  • gz
  • ico
  • ini
  • jpeg
  • jpg
  • json
  • less
  • map
  • md
  • mdown
  • mo
  • mp4
  • otf
  • pcss
  • pdf
  • po
  • pot
  • png
  • sass
  • scss
  • styl
  • ttf
  • txt
  • woff
  • woff2
  • yml

PHPCS configuration

PHPCS scanning enabled: true

PHPCS severity level: 1

Standard(s) used:

  • PHPCompatibility
  • PHPCompatibilityParagonieRandomCompat
  • PHPCompatibilityParagonieSodiumCompat
  • VariableAnalysis
  • WordPress

Runtime set:

  • testVersion 8.1-

Scan added/modified files with file extensions:

  • php
  • js
  • twig

Custom sniffs included:

  • Generic.PHP.DisallowShortOpenTag
  • Squiz.PHP.CommentedOutCode

Custom sniffs excluded:

  • WordPress.Security.EscapeOutput
  • WordPress.PHP.DevelopmentFunctions
  • WordPress.WP.AlternativeFunctions
  • WordPress.PHP.DiscouragedPHPFunctions
  • WordPress.Files.FileName
  • Squiz.Commenting.FileComment
  • Generic.PHP.Syntax

Directories not PHPCS scanned:

  • None

WPScan API configuration

WPScan API scanning enabled: true

WPScan API URL: https://wpscan.com/api/v3

Directories scanned:

  • plugins
  • client-mu-plugins
  • themes

Directories not scanned:

  • None

Scan added/modified plugins based on headers present in files with file extensions:

  • php

Scan added/modified themes based on headers present in files with file extensions:

  • css

@gudmdharalds gudmdharalds merged commit edcb7d3 into trunk Jun 12, 2023
@gudmdharalds gudmdharalds deleted the add/changelog-v1.3.4 branch June 12, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left review comments

Assignees
No one assigned
Labels
[ Type ] Changelog & version
Projects
None yet
Milestone
1.3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@gudmdharalds @wpcomvip-vipgoci-bot