Skip to content

Clean up, add error checking, remove ambiguity around term "port" #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2025
Merged

Clean up, add error checking, remove ambiguity around term "port" #1228

merged 7 commits into from
Mar 3, 2025

Conversation

ericfitz
Copy link
Collaborator

@ericfitz ericfitz commented Mar 3, 2025

Summary:
Cleans up vue.config.js to make clear what different "port" values are used for
Adds error checking for reading TLS certificate/key files
Fixes up references to renamed "PORT" variable in server app & tests
Reorganizes and heavily comments example.env

Description for the changelog:
Make configuration of custom ports easier and more understandable

@ericfitz ericfitz requested a review from jgadsden March 3, 2025 02:45
@ericfitz ericfitz requested a review from lreading March 3, 2025 03:02
@jgadsden jgadsden added enhancement New feature or request version-2.4.1 labels Mar 3, 2025
jgadsden
jgadsden approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@jgadsden jgadsden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good to have these changes @ericfitz , and very good to see the annotation to the example.env file
I am working on the documentation that may help as well
we have just released version 2.4.0, with version 2.5.0 scheduled 6 months away, but this is well worth putting into a version 2.4.1 which can potentially be released this month (March 2025) or mid next month

@jgadsden jgadsden added this to the Version 2.4.1 milestone Mar 3, 2025
lreading
lreading approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@lreading lreading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thanks @ericfitz 🎉

@ericfitz ericfitz merged commit 0a235a1 into OWASP:main Mar 3, 2025
1 check passed
@jgadsden
Copy link
Collaborator

jgadsden commented Mar 4, 2025 •
edited
Loading

@ericfitz we may have to revert this change for the now - we get Heroku errors:

2025-03-04T05:52:04.408739+00:00 heroku[web.1]: State changed from crashed to starting
2025-03-04T05:52:08.163573+00:00 heroku[web.1]: Starting process with command `td.server/index.js`
2025-03-04T05:52:10.075708+00:00 app[web.1]: Unable to find .env file, falling back to environment variables
2025-03-04T05:52:10.091403+00:00 app[web.1]: Express server listening at :: on port 3000
2025-03-04T05:53:08.553323+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
2025-03-04T05:53:08.565853+00:00 heroku[web.1]: Stopping process with SIGKILL
2025-03-04T05:53:08.630514+00:00 heroku[web.1]: Process exited with status 137
2025-03-04T05:53:08.654894+00:00 heroku[web.1]: State changed from starting to crashed

and the site no longer runs
I have tried setting both environment variables SERVER_API_PORT and PORT to 3000, but still the same

@jgadsden jgadsden mentioned this pull request Mar 4, 2025
Merged
@ericfitz ericfitz deleted the port-change branch March 7, 2025 16:35
@jgadsden jgadsden mentioned this pull request Mar 8, 2025
Closed
ericfitz added a commit to efitz-oss/threat-dragon that referenced this pull request Mar 26, 2025
@ericfitz
Fixed errors and resubmitting reverted change for issue OWASP#1228
e0987d9
@ericfitz ericfitz mentioned this pull request Mar 26, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lreading lreading lreading approved these changes

@jgadsden jgadsden jgadsden approved these changes

Assignees

@ericfitz ericfitz

Labels
enhancement New feature or request version-2.4.1
Projects
None yet
Milestone
Version 2.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ericfitz @jgadsden @lreading