Skip to content

replace helmet.xframe() with helmet.frameguard(), xframe is deprecated #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

replace helmet.xframe() with helmet.frameguard(), xframe is deprecated #118

wants to merge 2 commits into from

Conversation

nataliaero
Copy link

Replace helmet.xframe() with helmet.frameguard() as the xframe method is deprecated

@lirantal
Copy link
Collaborator

thanks, does frameguard() exist in the current version of helmet that we use in the project?

@lirantal lirantal self-requested a review February 26, 2019 11:40
@lirantal lirantal removed their assignment Feb 26, 2019
@UlisesGascon UlisesGascon mentioned this pull request Aug 4, 2019
Open
31 tasks
@UlisesGascon UlisesGascon changed the base branch from master to release-1.5 October 29, 2019 14:58
@UlisesGascon
Copy link
Collaborator

Same as #119. We can merge it also if you agree @ckarande :-)

@UlisesGascon UlisesGascon self-requested a review October 29, 2019 14:59
UlisesGascon
UlisesGascon approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :-)

@UlisesGascon
Copy link
Collaborator

@nataliaero I will re-integrate this change once #187 has been merged

@UlisesGascon UlisesGascon mentioned this pull request Mar 17, 2020
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lirantal lirantal Awaiting requested review from lirantal

Assignees

@ckarande ckarande

@UlisesGascon UlisesGascon

@nataliaero nataliaero

Labels
enhancement priority: MEDIUM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nataliaero @lirantal @UlisesGascon @ckarande