Skip to content

change app.csp() with contentSecurityPolicy() #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

change app.csp() with contentSecurityPolicy() #119

merged 1 commit into from
Nov 6, 2019

Conversation

NataliaRizzi
Copy link

No description provided.

@UlisesGascon UlisesGascon mentioned this pull request Aug 4, 2019
Open
31 tasks
@UlisesGascon UlisesGascon changed the base branch from master to release-1.5 October 29, 2019 14:54
@UlisesGascon UlisesGascon self-requested a review October 29, 2019 14:54
UlisesGascon
UlisesGascon approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon
Copy link
Collaborator

Thanks a lot for your support @NataliaRizzi! :-)

I assume that we can merge it. The Helmet API changed and this PR solve it. I changed the base branch from master to release-1.5

What do you think @ckarande? Should we merge it?

@UlisesGascon UlisesGascon mentioned this pull request Oct 29, 2019
Closed
@ckarande
Copy link
Member

ckarande commented Nov 5, 2019

LGTM. Yes, we can merge it! 👍

@UlisesGascon UlisesGascon merged commit 42aa35e into OWASP:release-1.5 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

@ckarande ckarande

@UlisesGascon UlisesGascon

Labels
enhancement priority: MEDIUM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NataliaRizzi @UlisesGascon @ckarande