Skip to content

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Feb 26, 2023

Closes #617

image

Now for circular corss sections we have drag formulation proposed in #617 zero lift and pitch. Also the interface has been simplified with a bluit-in default chord vector (in cases when the angle of incidence is not relevant) and numerical parameters such as numGaussPoints stifnessAeroBool and geometricNonLinear are set with default values.

@mvanzulli mvanzulli changed the title Built-in aerodynamic coefficients (#617) Built-in aerodynamic coefficients Feb 26, 2023
@mvanzulli
Copy link
Member Author

mvanzulli commented Feb 26, 2023

The proof of concept is done in the linear aerodynamics example

@jorgepz
Copy link
Member

jorgepz commented Feb 27, 2023

I suggest you update the branch @mvanzulli

@mvanzulli
Copy link
Member Author

I suggest you update the branch @mvanzulli

Great, now local and remote tests are failing. 👍🏼

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #636 (17a5558) into master (8a0bc95) will increase coverage by 0.34%.
The diff coverage is 84.12%.

❗ Current head 17a5558 differs from pull request most recent head b4eedf9. Consider uploading reports for the commit b4eedf9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   60.42%   60.77%   +0.34%     
==========================================
  Files         148      150       +2     
  Lines        4910     4928      +18     
==========================================
+ Hits         2967     2995      +28     
+ Misses       1943     1933      -10     
Impacted Files Coverage Δ
docs/src/bringONSASmFilesToONSASdocs.m 0.00% <0.00%> (ø)
examples/linearAerodynamics/linearAerodynamics.m 0.00% <0.00%> (ø)
...ples/nonLinearAerodynamics/nonLinearAerodynamics.m 0.00% <ø> (ø)
src/crossSections/crossSectionProps.m 46.87% <ø> (ø)
src/crossSections/innerDragCoefCircular.m 66.66% <66.66%> (ø)
.../dragBeamReconfiguration/dragBeamReconfiguration.m 98.43% <97.14%> (+8.13%) ⬆️
examples/VIVCantilever/VIVCantilever.m 98.03% <100.00%> (+0.03%) ⬆️
examples/simplePropeller/simplePropeller.m 98.61% <100.00%> (+0.01%) ⬆️
src/core/assembler.m 93.64% <100.00%> (+0.15%) ⬆️
src/crossSections/aeroCrossSectionProps.m 100.00% <100.00%> (ø)
... and 2 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mvanzulli mvanzulli marked this pull request as ready for review March 2, 2023 01:18
@mvanzulli
Copy link
Member Author

mvanzulli commented Mar 3, 2023

@jorgepz suggested:

  • Legend outside, make markers bigger.
  • Fix log log plot in the C.I

mvanzulli and others added 2 commits March 15, 2023 14:57
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli mvanzulli merged commit 89bbf63 into master Mar 15, 2023
@mvanzulli mvanzulli deleted the mvanzulli/617 branch March 15, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a more complete drag formulation for circular cross-sections
3 participants