Skip to content

docmodifications #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 23, 2022
Merged

docmodifications #528

merged 9 commits into from
Jul 23, 2022

Conversation

santiago-correa-89
Copy link
Contributor

No description provided.

jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
jorgepz
jorgepz reviewed Jul 23, 2022
View reviewed changes
@jorgepz jorgepz changed the base branch from master to jorge July 23, 2022 08:07
@jorgepz jorgepz changed the base branch from jorge to mvanzulli/docs July 23, 2022 08:09
@jorgepz
Copy link
Member

jorgepz commented Jul 23, 2022 •
edited
Loading

gracias @santiago-correa-89! hice unas sugerencias puntuales (más bien de inlgés)
además moví el branch de destino. lo ideal es que hagas un PR desde un branch en el propio repo de ONSAS para que se pueda hacer el deploy y se vea como queda la documentación final automáticamente en lugar de tener q leerlo en markdown...
en este caso para aprovechar lo que hiciste en tu fork, sugiero mergearlo en un branch del repo, por ejemplo el branch que @mvanzulli tiene abierto y luego unir todo para cerrar el issue completo.
si lo prefieren también santiago puede crear otro branch y hacer un PR aparte, pero no haría merge directo a master sin que veamos la docs con el deploy.

@jorgepz jorgepz requested a review from mvanzulli July 23, 2022 09:46
@mvanzulli
Copy link
Member

mvanzulli commented Jul 23, 2022 •
edited
Loading

Aguardo que Santi comiteen los cambios, mergeo en #526 y luego a master

mvanzulli
mvanzulli approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@mvanzulli mvanzulli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias Santi por agregar los cambios a la documentación, tremendo ejemplo test de dinámica!

santiago-correa-89 and others added 8 commits July 23, 2022 13:37
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
cc359d0 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
5f3b0b2 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
dddbecf 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
678f7cd 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
56dfc79 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
280e68f 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
e99762a 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@santiago-correa-89 @jorgepz
Update examples/beamLinearVibration/beamLinearVibration.m
ae18333 
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@mvanzulli mvanzulli merged commit a4e05c4 into ONSAS:mvanzulli/docs Jul 23, 2022
@santiago-correa-89 santiago-correa-89 deleted the fixDocLineaDeamVibration branch July 23, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepz jorgepz jorgepz left review comments

@mvanzulli mvanzulli mvanzulli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santiago-correa-89 @jorgepz @mvanzulli