Skip to content

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Jul 21, 2022

This PR update docs figures of examples:

  • uniform cantilever beam
  • spring mass
  • linear vibration beam

Indeed, this PR solves 2 sub-tasks described in #497

@jorgepz
Copy link
Member

jorgepz commented Jul 21, 2022

Awesome PR!
I suggest using the verb 'close' so that github understands and links the issue

@mvanzulli mvanzulli marked this pull request as ready for review July 22, 2022 11:23
@mvanzulli mvanzulli linked an issue Jul 22, 2022 that may be closed by this pull request
6 tasks
@mvanzulli mvanzulli changed the title fixing docs 💡 fixing docs 📚 Jul 22, 2022
@mvanzulli mvanzulli removed a link to an issue Jul 22, 2022
6 tasks
@mvanzulli mvanzulli requested a review from jorgepz July 22, 2022 16:04
jorgepz
jorgepz previously approved these changes Jul 23, 2022
@mvanzulli mvanzulli mentioned this pull request Jul 23, 2022
santiago-correa-89 and others added 9 commits July 23, 2022 13:37
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
Co-authored-by: Jorge Pérez Zerpa <42485529+jorgepz@users.noreply.github.com>
@jorgepz
Copy link
Member

jorgepz commented Jul 23, 2022

Selente. Ahora si....en https://onsas.github.io/ONSAS.m/previews/PR526/examples/beamLinearVibration/ se pueden ver varias cosas para arreglar...

@jorgepz jorgepz self-requested a review July 23, 2022 17:05
@jorgepz jorgepz dismissed their stale review July 23, 2022 17:05

Hay nuevos cambios

@jorgepz jorgepz removed their request for review July 23, 2022 17:06
@santiago-correa-89
Copy link
Contributor

Estoy trabajando en varios errores de formato y en agregar la imagen faltante. Tiene varios errores para seguir arreglando

@jorgepz
Copy link
Member

jorgepz commented Jul 23, 2022

No hay apuro @santiago-correa-89 . Cuando esté solícitas el review pero no tiene porque ser hoy!

@jorgepz jorgepz merged commit d761278 into master Aug 6, 2022
@jorgepz jorgepz deleted the mvanzulli/docs branch August 6, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants