Skip to content

add WOM VIV models #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 21, 2022
Merged

add WOM VIV models #518

merged 6 commits into from
Jul 21, 2022

Conversation

TheChikenfly
Copy link
Collaborator

fixing issue when windVel = 0 at t=0

@TheChikenfly TheChikenfly requested a review from mvanzulli July 9, 2022 15:16
@TheChikenfly TheChikenfly mentioned this pull request Jul 9, 2022
Closed
@TheChikenfly TheChikenfly linked an issue Jul 9, 2022 that may be closed by this pull request
Bug in HydroFrameForce #517
Closed
@TheChikenfly TheChikenfly removed a link to an issue Jul 9, 2022
Bug in HydroFrameForce #517
Closed
TheChikenfly added a commit that referenced this pull request Jul 9, 2022
@TheChikenfly
fixing issue #518
5e13a00
@TheChikenfly TheChikenfly linked an issue Jul 9, 2022 that may be closed by this pull request
Bug in HydroFrameForce #517
Closed
@mvanzulli
Copy link
Member

mvanzulli commented Jul 10, 2022 •
edited
Loading

You can notice that this presents conflicts and is not updated with master. As you said on gitter the line 195 of master function hydroFrameForces.m should be changed. I suggest to close this PR, and open two new ones.

  1. Solving line 195
  2. Adding WomV2 and circular lift coef functions.

mvanzulli
mvanzulli approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@mvanzulli mvanzulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funktastic!

@jorgepz jorgepz changed the title fixing HydroFrameForce add WOM VIV models Jul 21, 2022
@mvanzulli mvanzulli mentioned this pull request Jul 21, 2022
Merged
@TheChikenfly TheChikenfly merged commit 3cfe3b1 into master Jul 21, 2022
@jorgepz jorgepz deleted the WOMImplementation branch July 21, 2022 20:23
@jorgepz jorgepz mentioned this pull request Jul 27, 2022
Closed
2 tasks
jorgepz added a commit that referenced this pull request Aug 25, 2022
@jorgepz
Merge pull request #538 from ONSAS/517-bug-in-hydroframeforce
cfac35e 
fixing issue #518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvanzulli mvanzulli mvanzulli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in HydroFrameForce
2 participants
@TheChikenfly @mvanzulli