rpi-imager: 1.9.4 -> 1.9.6 #432698
Open
rpi-imager: 1.9.4 -> 1.9.6 #432698
+85
−571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@doronbehar Could you review this when you have some free time? Thanks. |
|
Hey, thanks for asking me for a review. Although I don't maintain this package, I pushed a change which I think is more correct, and should help us maintain this in an easier manner in the future. Starting next week, I'll be busy for 5-7 weeks, so I might not be able to respond to review requests. If upstream will accept my PR, this should be good to go as is. |
|
The CI errors are false negative I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.