Skip to content

Allow to build without vendoring #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

doronbehar
Copy link

Commits:

  • CMake: remove now not used nghttp2 dep
  • Try to fetch dependencies from system first

Purpose:

Make it easier for Arch Linux, Nix, and possibly others to distribute your package with the system installed dependencies.

@tdewey-rpi
Copy link
Collaborator

Thanks for the submission, @doronbehar

Unfortunately, I am absolutely refusing this PR. Vendoring has been discussed at length on the issue tracker, and I remain yet to be convinced that the users and maintainers of Imager gain anything from an alternative strategy.

You are, of course, free to maintain a fork. You should, however, be advised that I will not be considering the impact of build system rework on any forks - the users of Imager remain my primary concern.

@tdewey-rpi tdewey-rpi closed this Aug 22, 2025
@doronbehar
Copy link
Author

doronbehar commented Aug 24, 2025 via email

@lurch
Copy link
Contributor

lurch commented Aug 24, 2025

@tdewey-rpi could you please share with me a link to a discussion about vendoring? I didn't find any when I searched vendor before submitting the PR.

A search for "vendoring" finds a big discussion in #924

Also, could you please maybe review the 1st commit of this PR? It is related but should be separated from the anti-vendoring changes.

It might be better to submit that as a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants