Apply nixfmt #12349
Merged
Apply nixfmt #12349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do wonder if we should format the lang tests. After all, the parser should also work (and give correct position info) on inputs that aren't formatted correctly. Probably doesn't matter though... |
👍 I've excluded the Leaving them unformatted is annoying for contributors when enable format-on-save in their editor, so I think it's worth doing. |
... with nixfmt (rfc style)
8c89d57 to
c0e6692
Compare
|
I've reviewed the formatted |
Carefully reviewed...
roberth
added a commit
that referenced
this pull request
Jan 24, 2025
This does not include any automation for the release branch, but is based on that of #12349
roberth
added a commit
that referenced
this pull request
Jan 24, 2025
This does not include any automation for the release branch, but is based on the configuration of #12349 pre-commit run -a nixfmt-rfc-style
roberth
added a commit
that referenced
this pull request
Jan 24, 2025
is based on the configuration of #12349 pre-commit run -a nixfmt-rfc-style
roberth
added a commit
that referenced
this pull request
Jan 24, 2025
This does not include any automation for the release branch, but is based on the configuration of #12349 pre-commit run -a nixfmt-rfc-style
roberth
added a commit
that referenced
this pull request
Jan 24, 2025
This does not include any automation for the release branch, but is based on the configuration of #12349 pre-commit run -a nixfmt-rfc-style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RFC 166
Now is a good time, because we're pretty much up to speed with backports.
I'll apply it to current maintenance branches as well, so that automated backports remain possible.
I will not add the automation to the maintenance branches though.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.