fix box-box collision #839
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the DCO issue and also open a pull request into Newton, where a similar issue probably exists? |
ca2c832 to
762f6e3
Compare
Signed-off-by: Zhenggehan <gehan.zheng@vanderbilt.edu> (cherry picked from commit 762f6e3)
Signed-off-by: Zhenggehan <gehan.zheng@vanderbilt.edu> (cherry picked from commit 7f4c171dac19c0b0a1c454abb41b2a90af555d45)
d941a63 to
5d93b75
Compare
|
I've fixed it and have opened a pull request for Newton. |
Thank you! Since Eric reviewed and merged it into Newton, I'll get your fix into Warp this week. Please remind me if I forget... |
pull bot
pushed a commit
to mcx/warp
that referenced
this pull request
Jul 14, 2025
fix box-box collision (NVIDIAGH-839) See merge request omniverse/warp!1444
pull bot
pushed a commit
to mcx/warp
that referenced
this pull request
Jul 14, 2025
Signed-off-by: Eric Shi <ershi@nvidia.com>
pull bot
pushed a commit
to mcx/warp
that referenced
this pull request
Jul 14, 2025
Add a missing changelog entry for NVIDIAGH-839 See merge request omniverse/warp!1446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed box-box collision by computing the normal with the closest point instead of the center of the box A when computing the distance.
Before your PR is "Ready for review"
__init__.pyi,functions.rst)pre-commit run -a