Skip to content

fix: address double bos in eval task #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix: address double bos in eval task #962

merged 2 commits into from
Sep 4, 2025

Conversation

ZhiyuLi-Nvidia
Copy link
Contributor

@ZhiyuLi-Nvidia ZhiyuLi-Nvidia commented Aug 21, 2025 •
edited
Loading

What does this PR do ?

As titled, address double bos issue all over the repo. The missing part is mainly in eval.
#855

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

yuki-97
yuki-97 reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@yuki-97 yuki-97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@terrykong terrykong added this pull request to the merge queue Aug 28, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2025
@ZhiyuLi-Nvidia @yuki-97
fix: address double bos in eval task (#962)
f77bdf2 
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2025
@ZhiyuLi-Nvidia ZhiyuLi-Nvidia force-pushed the zhiyul/address_double_bos branch from 2c0c4f0 to 68043c9 Compare August 28, 2025 22:18
ZhiyuLi-Nvidia and others added 2 commits August 31, 2025 00:28
@ZhiyuLi-Nvidia
fix: address double bos in eval
cb39789 
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
@ZhiyuLi-Nvidia @yuki-97
Update tests/unit/data/test_data_processor.py
19670db 
Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
@ZhiyuLi-Nvidia ZhiyuLi-Nvidia force-pushed the zhiyul/address_double_bos branch from 68043c9 to 19670db Compare August 31, 2025 00:28
@terrykong terrykong added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@terrykong terrykong added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 3, 2025
@terrykong terrykong added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 2b55598 Sep 4, 2025
21 checks passed
@terrykong terrykong deleted the zhiyul/address_double_bos branch September 4, 2025 02:29
wangshangsam pushed a commit that referenced this pull request Sep 4, 2025
@ZhiyuLi-Nvidia @yuki-97 @wangshangsam
fix: address double bos in eval task (#962)
0b83744 
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com>
Signed-off-by: Shang Wang <samshang.wang@mail.utoronto.ca>
terrykong pushed a commit that referenced this pull request Sep 6, 2025
@ZhiyuLi-Nvidia @yuki-97 @terrykong
fix: address double bos in eval task (#962)
4ee7994 
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
Co-authored-by: Yuki Huang <48991475+yuki-97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@yuki-97 yuki-97 yuki-97 approved these changes

@parthchadha parthchadha Awaiting requested review from parthchadha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhiyuLi-Nvidia @terrykong @yuki-97