-
Notifications
You must be signed in to change notification settings - Fork 130
test: enable 8k/16k/24k deepscaler nightly tests #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terry Kong <terryk@nvidia.com> updated recipes + hacks Signed-off-by: Terry Kong <terryk@nvidia.com> better for memory Signed-off-by: Terry Kong <terryk@nvidia.com> adjust step time Signed-off-by: Terry Kong <terryk@nvidia.com> fix steps Signed-off-by: Terry Kong <terryk@nvidia.com> disable eval this round Signed-off-by: Terry Kong <terryk@nvidia.com> comment Signed-off-by: Terry Kong <terryk@nvidia.com> lint Signed-off-by: Terry Kong <terryk@nvidia.com> revert Signed-off-by: Terry Kong <terryk@nvidia.com> fix some config issues uncovered by placing configs in the correct dir Signed-off-by: Terry Kong <terryk@nvidia.com> chore: enable accuracy test for deepscaler + enable 16k and 24k tests Signed-off-by: Terry Kong <terryk@nvidia.com> get recipes right Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
commented
Aug 17, 2025
yuki-97
reviewed
Aug 18, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
yuki-97
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! LGTM except the below two questions.
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
yuki-97
approved these changes
Aug 18, 2025
jveronvialard
pushed a commit
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 16k and 24k tests run in the CI with 8k and 16k staged checkpoints, but external users can still run these with the base checkpoint since the metric check always makes sure it doesn't regress against the base checkpoint