Skip to content

docs: add usage example for mcore --> hf converter #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2025
Merged

docs: add usage example for mcore --> hf converter #807

merged 4 commits into from
Jul 31, 2025

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jul 30, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ashors1
add usage example for mcore --> hf converter
eb52359 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 requested a review from terrykong July 30, 2025 23:18
@ashors1 ashors1 mentioned this pull request Jul 30, 2025
Closed
parthchadha
parthchadha previously approved these changes Jul 30, 2025
View reviewed changes
@terrykong
Copy link
Contributor

maybe worth generalizing this doc:

https://github.com/NVIDIA-NeMo/RL/blob/main/docs/design-docs/checkpointing.md#checkpointing-with-hugging-face-models

@ashors1
update documentation
56dec71 
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2025
@ashors1
improvement
36290b3 
Signed-off-by: ashors1 <ashors@nvidia.com>
terrykong
terrykong reviewed Jul 31, 2025
View reviewed changes
@abdalgader-a
Copy link
Contributor

@ashors1 -- I'd suggest also to update this section of README.md if possible.

@ashors1
update readme, address comment
b42e714 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Copy link
Contributor Author

ashors1 commented Jul 31, 2025

@ashors1 -- I'd suggest also to update this section of README.md if possible.

Good suggestion, done. Thanks!

@terrykong terrykong enabled auto-merge July 31, 2025 17:02
@terrykong terrykong added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 4365402 Jul 31, 2025
15 checks passed
@terrykong terrykong deleted the ashors/hf-export-note branch July 31, 2025 20:56
@abdalgader-a abdalgader-a mentioned this pull request Aug 1, 2025
Merged
4 tasks
tpoisonooo pushed a commit to tpoisonooo/RL that referenced this pull request Aug 4, 2025
@ashors1 @tpoisonooo
docs: add usage example for mcore --> hf converter (NVIDIA-NeMo#807)
8636efa 
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1
docs: add usage example for mcore --> hf converter (NVIDIA-NeMo#807)
d508334 
Signed-off-by: ashors1 <ashors@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
@ashors1 @soodoshll
docs: add usage example for mcore --> hf converter (NVIDIA-NeMo#807)
06f2a16 
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@parthchadha parthchadha parthchadha left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashors1 @terrykong @abdalgader-a @parthchadha