Skip to content

fix: guard DPO against dynamic batching and sequence packing #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

fix: guard DPO against dynamic batching and sequence packing #730

merged 3 commits into from
Jul 24, 2025

Conversation

ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jul 23, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ashors1
guard DPO against dynamic batching and sequence packing
cf44279 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 marked this pull request as ready for review July 23, 2025 21:08
terrykong
terrykong reviewed Jul 23, 2025
View reviewed changes
SahilJain314
SahilJain314 previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@SahilJain314 SahilJain314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending existing comment

@ashors1
link to issue
88e1cf4 
Signed-off-by: ashors1 <ashors@nvidia.com>
terrykong
terrykong previously approved these changes Jul 23, 2025
View reviewed changes
@terrykong terrykong added the r0.3.0 Release r0.3.0 label Jul 23, 2025
@ashors1
lint
cad6372 
Signed-off-by: ashors1 <ashors@nvidia.com>
@terrykong terrykong enabled auto-merge July 23, 2025 23:09
@terrykong terrykong added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 24, 2025
@terrykong terrykong added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 7c81f85 Jul 24, 2025
15 of 16 checks passed
@terrykong terrykong deleted the ashors/guard-dpo branch July 24, 2025 03:16
chtruong814 pushed a commit that referenced this pull request Jul 24, 2025
@ashors1
fix: guard DPO against dynamic batching and sequence packing (#730)
dcaaba3 
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 28, 2025
@ashors1 @xxman-google
fix: guard DPO against dynamic batching and sequence packing (NVIDIA-…
763814a 
…NeMo#730)

Signed-off-by: ashors1 <ashors@nvidia.com>
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
@ashors1 @rohitrango
fix: guard DPO against dynamic batching and sequence packing (#730)
395e9a4 
Signed-off-by: ashors1 <ashors@nvidia.com>
wedu-nvidia pushed a commit to wedu-nvidia/RL that referenced this pull request Jul 30, 2025
@ashors1 @wedu-nvidia
fix: guard DPO against dynamic batching and sequence packing (NVIDIA-…
dbc6733 
…NeMo#730)

Signed-off-by: ashors1 <ashors@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
@ashors1 @xxman-google
fix: guard DPO against dynamic batching and sequence packing (NVIDIA-…
5e089c0 
…NeMo#730)

Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1
fix: guard DPO against dynamic batching and sequence packing (NVIDIA-…
b86fa2b 
…NeMo#730)

Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1 @xxman-google
fix: guard DPO against dynamic batching and sequence packing (NVIDIA-…
e05668a 
…NeMo#730)

Signed-off-by: ashors1 <ashors@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
@ashors1 @soodoshll
fix: guard DPO against dynamic batching and sequence packing (NVIDIA-…
d334ae2 
…NeMo#730)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
jiemingz pushed a commit that referenced this pull request Aug 20, 2025
@ashors1
fix: guard DPO against dynamic batching and sequence packing (#730)
aa2664c 
Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@SahilJain314 SahilJain314 SahilJain314 left review comments

Assignees
No one assigned
Labels
r0.3.0 Release r0.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashors1 @terrykong @SahilJain314