Skip to content

fix: unset TP and PP in sft 1 GPU config #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

fix: unset TP and PP in sft 1 GPU config #717

merged 1 commit into from
Jul 23, 2025

Conversation

terrykong
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@terrykong
fix: unset TP and PP in sft 1 GPU config
da8d6a8 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong requested a review from ashors1 July 23, 2025 04:58
@terrykong terrykong added the r0.3.0 Release r0.3.0 label Jul 23, 2025
@terrykong terrykong added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit a607b41 Jul 23, 2025
25 of 27 checks passed
@terrykong terrykong deleted the tk/unset-parallelism-in-sft branch July 23, 2025 08:33
chtruong814 pushed a commit that referenced this pull request Jul 23, 2025
@terrykong
fix: unset TP and PP in sft 1 GPU config (#717)
750c173 
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 28, 2025
@terrykong @xxman-google
fix: unset TP and PP in sft 1 GPU config (NVIDIA-NeMo#717)
4958ca2 
Signed-off-by: Terry Kong <terryk@nvidia.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
@terrykong @KiddoZhu
fix: unset TP and PP in sft 1 GPU config (#717)
59cd464 
Signed-off-by: Terry Kong <terryk@nvidia.com>
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
@terrykong @rohitrango
fix: unset TP and PP in sft 1 GPU config (#717)
44bc48f 
Signed-off-by: Terry Kong <terryk@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
@terrykong @xxman-google
fix: unset TP and PP in sft 1 GPU config (NVIDIA-NeMo#717)
e195cb6 
Signed-off-by: Terry Kong <terryk@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@terrykong
fix: unset TP and PP in sft 1 GPU config (NVIDIA-NeMo#717)
e4a692c 
Signed-off-by: Terry Kong <terryk@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@terrykong @xxman-google
fix: unset TP and PP in sft 1 GPU config (NVIDIA-NeMo#717)
4fb7310 
Signed-off-by: Terry Kong <terryk@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
@terrykong @soodoshll
fix: unset TP and PP in sft 1 GPU config (NVIDIA-NeMo#717)
a4ea0af 
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashors1 ashors1 ashors1 approved these changes

Assignees
No one assigned
Labels
r0.3.0 Release r0.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrykong @ashors1