Skip to content

Conversation

RayenTian
Copy link
Contributor

What does this PR do ?

This PR fixes the following warning raised by the Python interpreter:

SyntaxWarning: invalid escape sequence '\s'

This happens when Python's raw strings are not used in regular expressions containing escape sequences such as \s, \d, etc. Replaced regular string literals with raw string literals by prefixing with r in regex patterns.

Signed-off-by: ruit <ruit@nvidia.com>
@RayenTian RayenTian requested a review from yuki-97 July 22, 2025 04:41
@RayenTian RayenTian added the CI:L1 Run doctests, unit tests, and functional tests label Jul 22, 2025
Copy link
Contributor

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah hah! so that's where that warning was coming from. thanks for making our logging cleaner

@parthchadha parthchadha added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit accd308 Jul 22, 2025
25 of 27 checks passed
@parthchadha parthchadha deleted the ruit/fix_invalid_escape_warning branch July 22, 2025 19:02
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 28, 2025
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: ruit <ruit@nvidia.com>
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
Signed-off-by: ruit <ruit@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:L1 Run doctests, unit tests, and functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants