chore: add CP+SP (sequence parallel) assertion in DTensor worker #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b207b9a to
b6bb3d2
Compare
terrykong
previously approved these changes
Jul 18, 2025
|
test failure, i'll address |
terrykong
previously approved these changes
Jul 19, 2025
terrykong
approved these changes
Jul 19, 2025
31b545e to
7ff3466
Compare
terrykong
approved these changes
Jul 19, 2025
c7d3b0a to
8e61bb0
Compare
Signed-off-by: Yuki Huang <yukih@nvidia.com> fix: change sp+tp assert to warning and fix unit test order (#696) Signed-off-by: Terry Kong <terryk@nvidia.com> update assert Co-authored-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com>
8e61bb0 to
dd7cf31
Compare
SahilJain314
pushed a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
SahilJain314
pushed a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
…DIA-NeMo#689) Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
rohitrango
pushed a commit
that referenced
this pull request
Jul 29, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
…DIA-NeMo#689) Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…DIA-NeMo#689) Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…DIA-NeMo#689) Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
…DIA-NeMo#689) Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an assertion to avoid using CP+SP (sequence parallel) in DTensor worker.
Related issue: #659.