Skip to content

Conversation

yfw
Copy link
Contributor

@yfw yfw commented Jul 16, 2025

What does this PR do ?

Gemma models were broken in NeMo-RL and vLLM by this HF commit: huggingface/transformers#37033. To address this:

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@yfw yfw requested a review from terrykong July 16, 2025 03:29
@terrykong terrykong added the r0.3.0 Release r0.3.0 label Jul 16, 2025
yfw added 5 commits July 16, 2025 11:32
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
parthchadha
parthchadha previously approved these changes Jul 16, 2025
terrykong
terrykong previously approved these changes Jul 16, 2025
@terrykong terrykong added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2025
yfw added 2 commits July 16, 2025 16:43
@yfw yfw dismissed stale reviews from terrykong and parthchadha via d64df28 July 17, 2025 00:10
@yfw yfw added the CI:L0 Run doctests and unit tests label Jul 17, 2025
@yfw yfw added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels Jul 17, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw yfw added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels Jul 17, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw yfw added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels Jul 17, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@yfw yfw added CI:L0 Run doctests and unit tests and removed CI:L0 Run doctests and unit tests labels Jul 18, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
@terrykong terrykong added this pull request to the merge queue Jul 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2025
@terrykong terrykong added this pull request to the merge queue Jul 19, 2025
Merged via the queue into main with commit 124ca30 Jul 19, 2025
13 of 14 checks passed
@terrykong terrykong deleted the yifu/gemma_fix branch July 19, 2025 02:23
SahilJain314 pushed a commit that referenced this pull request Jul 21, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
SahilJain314 pushed a commit that referenced this pull request Jul 21, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:L0 Run doctests and unit tests r0.3.0 Release r0.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants