fix: Make trust_remote_code default true in checkpoint #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
|
given this is already enabled elsewhere in the code I have no objections. Only thing is if we should change it all to a variable instead. But that's probably a separate issue |
gshennvm
approved these changes
Jul 14, 2025
terrykong
approved these changes
Jul 14, 2025
ZhiyuLi-Nvidia
pushed a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information